Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove old awssec package from imports #8

Merged
merged 1 commit into from
Oct 25, 2019
Merged

fix: Remove old awssec package from imports #8

merged 1 commit into from
Oct 25, 2019

Conversation

klebediev
Copy link
Contributor

otherwise we'll get:

$ make
go build -o bin/vals ./cmd/vals
go: finding github.com/variantdev/vals/pkg/providers/awssecrets latest
go: finding github.com/variantdev/vals/pkg latest
go: finding github.com/variantdev/vals/pkg/providers latest
build github.com/variantdev/vals/cmd/vals: cannot load github.com/variantdev/vals/pkg/providers/awssecrets: no matching versions for query "latest"
make: *** [build] Error 1

@klebediev klebediev mentioned this pull request Oct 25, 2019
Merged
mumoshu
mumoshu approved these changes Oct 25, 2019
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Thanks. Not sure how it slipped my manual tests...

@mumoshu mumoshu merged commit 6565695 into helmfile:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klebediev @mumoshu