-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration with Hashicorp Vault, AWS SSM, SecretsManager #906
Conversation
Fields which are rendered: Release.Values, Release.SetValues.Value, Release.SetValues.Values Example: ``` values: - foo: ref+vault://127.0.0.1:8200/mykv/foo?proto=http#/mykey set: - name: xyz values: - ref+vault://127.0.0.1:8200/mykv/foo?proto=http#/mykey3 ``` Resolves roboll#881
I need this |
@klebediev Thanks a lot for the PR! I'm super excited to finally get this into Helmfile 🎉 This generally LGTM. The only thing I wanted to do before merging this is to consult you about the latest changes I've made in The biggest improvement (I believe it is) is the use of The usage examples can be found at: https://github.com/variantdev/vals#suported-backends Does it look good to you? If so, please update the Thanks in advance for your support! |
Hi @mumoshu ! I like your latest improvements to So, waiting for you to merge above PR tp |
@klebediev Thanks for the confirmation and submitting the PR! I've just merged it and also implemented the enhancement to the vault provider. Hope you like it. |
New ref+.\* secret formats are used: https://github.com/variantdev/vals/tree/6565695a031f407a1066bdd31ae313db6a33ec0a#suported-backends Resolves roboll#881
a98c0a8
to
f49e7b0
Compare
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot for your contribution, @klebediev!
Let's merge this and see how it works in the wild. Fingers crossed.
I've updated the PR description to accomodate the latest syntax. |
This should resolve #745 as well. |
v0.89.0 is live with this feature. |
Thank you so much! |
@mumoshu @klebediev thank you both so much for the fast turnaround on this functionality :) You managed to get this designed, implemented, and released within the timeline of my Helm POC. |
Is possible to get all secrets from aws secrets manager and map as environment variable in the deployment using it in a helm chart repository that then we run with helmfile ? |
Fields which are rendered: Release.Values, Release.SetValues.Value, Release.SetValues.Values
Example:
Resolves #881