-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expand errer (!) in a config block - can't process "://"? #973
Labels
Comments
mumoshu
added a commit
that referenced
this issue
Nov 17, 2019
Those are not actually random but would have looked like so. We use an external go pkg `variantdev/vals` to expand urls like `ref+vault://foo/bar` contained in release values into their respective secret values. There was a bug in `vals` that it tries to expand unintended types of strings which resulted in confusing errors like reported in #973. `vals` fixed the issue in helmfile/vals@ba4c7a2. This commit upgrades `vals` to accomodate that. Fixes #973
mumoshu
added a commit
that referenced
this issue
Nov 17, 2019
Those are not actually random but would have looked like so. We use an external go pkg `variantdev/vals` to expand urls like `ref+vault://foo/bar` contained in release values into their respective secret values. There was a bug in `vals` that it tries to expand unintended types of strings which resulted in confusing errors like reported in #973. `vals` fixed the issue in helmfile/vals@ba4c7a2. This commit upgrades `vals` to accomodate that. Fixes #973
mumoshu
added a commit
that referenced
this issue
Nov 17, 2019
…974) Those are not actually random but would have looked like so. We use an external go pkg `variantdev/vals` to expand urls like `ref+vault://foo/bar` contained in release values into their respective secret values. There was a bug in `vals` that it tries to expand unintended types of strings which resulted in confusing errors like reported in #973. `vals` fixed the issue in helmfile/vals@ba4c7a2. This commit upgrades `vals` to accomodate that. Fixes #973
@mumoshu Yes, this fixes it :) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I ship an nginx config in a config block, and it trips up helmfile, but is ok with helm (and k8s) itself.
The offender seems to be
return 301 $scheme://$host:$server_port/remote.php/dav;
The text was updated successfully, but these errors were encountered: