Fix random "expansion errors" in large values contained in values
#974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are not actually random but would have looked like so. We use an external go pkg `variantdev/vals` to expand urls like `ref+vault://foo/bar` contained in release values into their respective secret values. There was a bug in `vals` that it tries to expand unintended types of strings which resulted in confusing errors like reported in #973. `vals` fixed the issue in helmfile/vals@ba4c7a2. This commit upgrades `vals` to accomodate that. Fixes #973
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are not actually random but would have looked like so. We use an external go pkg
variantdev/valsto expand urls likeref+vault://foo/barcontained in release values into their respective secret values.There was a bug in
valsthat it tries to expand unintended types of strings which resulted in confusing errors like reported in #973.valsfixed the issue in helmfile/vals@ba4c7a2. This commit upgradesvalsto accomodate that.Fixes #973