Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random "expansion errors" in large values contained in values #974

Merged
merged 1 commit into from
Nov 17, 2019

Commits on Nov 17, 2019

  1. Fix random "expansion errors" in large values contained in values

    Those are not actually random but would have looked like so. We use an external go pkg `variantdev/vals` to expand urls like `ref+vault://foo/bar` contained in release values into their respective secret values.
    
    There was a bug in `vals` that it tries to expand unintended types of strings which resulted in confusing errors like reported in #973.
    
    `vals` fixed the issue in helmfile/vals@ba4c7a2. This commit upgrades `vals` to accomodate that.
    
    Fixes #973
    mumoshu committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    5f8a4c2 View commit details
    Browse the repository at this point in the history