Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prdefined Filter searching type and List control #305

Closed
jimmy123j opened this issue May 11, 2021 · 2 comments
Closed

Prdefined Filter searching type and List control #305

jimmy123j opened this issue May 11, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@jimmy123j
Copy link

jimmy123j commented May 11, 2021

Sorry for bother again, Predefined Filter is good function for me
I think List control (with searching type) as Highlight Option might good for Prdefined Filter to use
And default the Prdefined Filter searching type in Option for using | multiple searching

List Control for Quick Searching
image

No searching type
image

Prdefined Filter searching type for | multiple searching
image

@variar
Copy link
Owner

variar commented May 11, 2021

Thanks for the feedback. Selecting multiple predefined filters has meaning only in "regular expression" mode. Mode setting for individual patterns in predefined filters edit dialog is on todo list. Building combined expression will take it into account and do escaping for those patterns that are set to "fixed strings".

I'm not sure what is list control? Buttons to move patterns up|down in edit dialog is on todo list. See #243

variar added a commit that referenced this issue Jun 8, 2021
Predefined filter pattern should be escaped if pattern is representing
fixed string with special characters
@variar variar self-assigned this Jul 25, 2021
@variar
Copy link
Owner

variar commented Jul 25, 2021

Changing order of patterns as well as search mode for each pattern has been added. Could you check it out in latest builds?

@variar variar added this to the 2021.07 milestone Jul 25, 2021
@variar variar added the status: ready for testing resolved but needs testing label Jul 25, 2021
@variar variar closed this as completed Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants