colors do not show up in the (color label) context menu

[burg1ar]

klogg version: klogg 22.06.0.1289
os: ubuntu 22.04

this seems to be a bug according to #270

[variar]

Unfortunately, this seems to be a Qt 5 issue in Linux. For Qt6 it works fine, so I've enabled it for Qt6 builds

[nowhszh]

klogg/src/ui/src/abstractlogview.cpp

Lines 694 to 701 in 26b39ea

	QPixmap pixmap( 20, 10 );
	auto fillColor = currentLabelConfiguration.color.backColor;
	fillColor.setAlphaF( 1.0 );
	pixmap.fill( fillColor );
	colorLabelAction->setIcon( QIcon( pixmap ) );
	#if defined( Q_OS_WIN ) || QT_VERSION >= QT_VERSION_CHECK( 6, 0, 0 )
	colorLabelAction->setIconVisibleInMenu( true );
	#endif

I do not understand the problem, comment out lines 699 and 701, using Qt5.12 compile, the color display is normal

[nowhszh]

I will verify this again using branch tag v22.06

[nowhszh]

@variar

klogg/src/ui/src/abstractlogview.cpp

Lines 494 to 501 in f96f35d

	QPixmap pixmap( 20, 10 );
	auto fillColor = currentLabelConfiguration.color.backColor;
	fillColor.setAlphaF( 1.0 );
	pixmap.fill( fillColor );
	colorLabelAction->setIcon( QIcon( pixmap ) );
	#ifdef Q_OS_WIN
	colorLabelAction->setIconVisibleInMenu( true );
	#endif

The code in tag v22.06 only displays color icons in klogg for Windows platform. setIconVisibleInMenu function was introduced in Qt4.4, I actually tested in Mac and Ubuntu are working properly, why is it enabled only in Windows?

[nowhszh]

I will verify this again using branch tag v22.06

After commenting out the code it works fine

[variar]

There were some rendering issues with Qt5 and KDE setup. If I remember correctly there were black squares instead of colors. I can't reproduce it anymore, something in my system got updated and fixed the issue. I guess it could be enabled back on older versions of Qt.

[nowhszh]

@variar I also have no problems with multiple computers, and I also think I can re-enable

[variar]

Enabled for all builds in 23.06.0.1538+