Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify props definition and optimize types #1160

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

chouchouji
Copy link
Member

@chouchouji chouchouji commented Aug 25, 2023

Checklist

List of tasks you have already done and plan to do.

  • simplify props definition and optimize types

Change information

Describe your modifications here.

Issues

The issues you want to close, formatted as close #1.

Related Links

Links related to this pr.

@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
varlet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 2:49am

@vercel
Copy link

vercel bot commented Aug 25, 2023

Someone is attempting to deploy a commit to the varletjs Team on Vercel.

A member of the Team first needs to authorize it.

@chouchouji chouchouji changed the title refactor: simplify rate and result props definition and optimize types refactor: simplify props definition and optimize types Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #1160 (ebdd792) into dev (715193b) will decrease coverage by 0.03%.
Report is 4 commits behind head on dev.
The diff coverage is 100.00%.

❗ Current head ebdd792 differs from pull request most recent head 9bfe114. Consider uploading reports for the commit 9bfe114 to get more accurate results

@@            Coverage Diff             @@
##              dev    #1160      +/-   ##
==========================================
- Coverage   95.68%   95.65%   -0.03%     
==========================================
  Files         337      337              
  Lines       22061    21771     -290     
  Branches     2155     2135      -20     
==========================================
- Hits        21110    20826     -284     
+ Misses        900      894       -6     
  Partials       51       51              
Files Changed Coverage Δ
packages/varlet-ui/src/rate/Rate.vue 93.47% <100.00%> (-0.48%) ⬇️
packages/varlet-ui/src/rate/props.ts 100.00% <100.00%> (ø)
packages/varlet-ui/src/result/props.ts 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants