-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(swipe): support navigation prop and prev&next slots #1177
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Someone is attempting to deploy a commit to the varletjs Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #1177 +/- ##
==========================================
+ Coverage 92.99% 93.00% +0.01%
==========================================
Files 284 284
Lines 6226 6237 +11
Branches 1508 1515 +7
==========================================
+ Hits 5790 5801 +11
Misses 373 373
Partials 63 63
☔ View full report in Codecov by Sentry. |
How do you think about exporting some parameters like indicator slot?If I have three swipe items, I want to realize that when the third item is reached, the next button cannot be clicked. Exporting these params will make it more convenient. @haoziqaq |
BTW. expose more useful attributes can make DX better. I think it's worth. |
Yes! I will add this after a while. |
d7aab4c
to
27ffa4a
Compare
dbd2ee5
to
6a6a0fb
Compare
Checklist
List of tasks you have already done and plan to do.
Change information
Describe your modifications here.
Issues
The issues you want to close, formatted as close #1.
Related Links
Links related to this pr.