Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swipe): support navigation prop and prev&next slots #1177

Merged
merged 9 commits into from
Sep 18, 2023

Conversation

chouchouji
Copy link
Member

@chouchouji chouchouji commented Sep 8, 2023

Checklist

List of tasks you have already done and plan to do.

  • Fix linting errors
  • Tests have been added / updated (or snapshots)
  • add hover effect

Change information

Describe your modifications here.

Issues

The issues you want to close, formatted as close #1.

Related Links

Links related to this pr.

@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
varlet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 10:01am
varlet-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 10:01am

@vercel
Copy link

vercel bot commented Sep 8, 2023

Someone is attempting to deploy a commit to the varletjs Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (c640f5d) 92.99% compared to head (6a6a0fb) 93.00%.
Report is 10 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1177      +/-   ##
==========================================
+ Coverage   92.99%   93.00%   +0.01%     
==========================================
  Files         284      284              
  Lines        6226     6237      +11     
  Branches     1508     1515       +7     
==========================================
+ Hits         5790     5801      +11     
  Misses        373      373              
  Partials       63       63              
Files Changed Coverage Δ
packages/varlet-ui/src/swipe/props.ts 100.00% <ø> (ø)
packages/varlet-ui/src/swipe/Swipe.vue 93.54% <100.00%> (+0.34%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chouchouji chouchouji changed the title WIP(swipe): support prev and next slots WIP(swipe): support navigation prop and prev&next slots Sep 8, 2023
@chouchouji
Copy link
Member Author

chouchouji commented Sep 8, 2023

How do you think about exporting some parameters like indicator slot?If I have three swipe items, I want to realize that when the third item is reached, the next button cannot be clicked. Exporting these params will make it more convenient. @haoziqaq

@nonzzz
Copy link
Contributor

nonzzz commented Sep 8, 2023

BTW. expose more useful attributes can make DX better. I think it's worth.

@chouchouji
Copy link
Member Author

BTW. expose more useful attributes can make DX better. I think it's worth.

Yes! I will add this after a while.

@chouchouji chouchouji changed the title WIP(swipe): support navigation prop and prev&next slots feat(swipe): support navigation prop and prev&next slots Sep 11, 2023
@haoziqaq haoziqaq merged commit d717f0c into varletjs:dev Sep 18, 2023
@chouchouji chouchouji deleted the feat-swipe branch September 19, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants