Allow setting the bridge with an env var #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gets tedious to always use: --bridge="$VARLINK_BRIDGE" Better if it can be given as an environment variable.
This was referenced Jan 12, 2019
afbjorklund
added a commit
to boot2podman/machine
that referenced
this pull request
Jun 1, 2019
For some reason it just ended up as blank Also VARLINK_BRIDGE environment variable is being ignored upstream, so use the PODMAN_VARLINK_BRIDGE as the documented variable for now. varlink/libvarlink#10 varlink/go#3
|
Will use the explicit parameter, if you are not accepting patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets tedious to always use: --bridge="$VARLINK_BRIDGE"
Better if it can be given as an environment variable.