Changed Singapore dollar sign to 'S$' #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
I'm currently using the library, and I think I found a case where a currency symbol is ambiguous.
For Singapore currency sign, I think it can be changed from just
$
toS$
(wikipedia), since currently I'm supporting both the USD & SGD currency, and it's kinda confusing when both are displayedThe sign symbol seems to be outside of the scope of the ISO, so I'm guessing it's fine since there doesn't seem to be any standard for it