fix!: use native fetch API #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
requested changes
Nov 6, 2023
There was a problem hiding this comment.
This PR needs to remove use of native-fetch as well, and just use the global fetch function.
CI still passes because native-fetch checks for the existence of global fetch first, but it's redundant now since all supported environments have a global fetch function.
achingbrain
approved these changes
Nov 6, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
## [3.0.0](v2.1.3...v3.0.0) (2023-11-06) ### ⚠ BREAKING CHANGES * requires node 18+ ### Bug Fixes * use native fetch API ([#104](#104)) ([58453c7](58453c7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 18 now has global fetch and given that electron now ships with node 18 by default , I don't think we need this peer-dependency anymore.
Related: #78