rebase #2
Merged
rebase #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a number of unused fields on a Kubernetes account. I think many of them were used in V1 accounts, but are now never read. As I was going through these as part of adding fields to kleat, removing the ones that I determined are not used.
Co-authored-by: root <root@c320d4c3c16f>
Co-authored-by: root <root@8bcd4d2873be>
Co-authored-by: root <root@f84528c7f520>
This is an incomplete migration of the TrafficGuard class (and supporting classes) from Orca. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: root <root@c55a81492b7a>
) * refactor(kubernetes): Clean up EnableDisableManifestDescription Mostly the goal here is to make loadBalancers Nonnull, which required overriding the lombok-generated accessor so that we can translate a null that's passed in to an empty list. While here, make the list immutable. Also add some tests, particularly on deserialization. I did *not* make the class immutable because one must draw some line at which to stop refactoring. * refactor(kubernetes): Make KubernetesManifestTraffic null-safe Also make it immutable, and add some tests. * fix(kubernetes): Fail with a useful message if manifest not found This commit adds nullity annotations to a number of functions related to the disable manifest stage so that we can better understand what can be null. It then throws a useful error message when a requested manifest is null, preventing what was a downstream error far from the actual issue (and that had less information about the error). * fix(kubernetes): Add missing parenthesis Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: root <root@8dce36ec7ef6> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This allows operations to be versioned within the same provider version. Having this capability will make it easier for us to migrate cloud-specific logic in Orca stages to Clouddriver, without breaking existing stages. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: root <root@bd79e168cfe6>
Locally, this improves the performance for this endpoint by about 12% (for large applications) Removing fetching a few relationships since they aren't used and also don't calculate `isHealthy` since it's not used/serialized
Co-authored-by: root <root@1dccf7052742>
Deploying to GAE using GCS throws stderr: ERROR: (gcloud.app.deploy) [...app.yaml] does not exist. The error occurs because GcsStorageService creates directories as files, and later files in the directory fail to created. Later, we determined Google Console UI was creating placeholder objects for folders. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: root <root@7e8575a6110c>
Co-authored-by: root <root@1bacecaea1dd>
I also changed the clouddriver API for this functionality to match the new terminology. Since the only client of this API (deck) has it hidden behind a feature flag, I felt okay about breaking the API to make the code less confusing. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: root <root@977a36312434>
Co-authored-by: root <root@59d9c736198e>
Co-authored-by: root <root@3d8bb27683f8>
…uple from cache refresh interval (#4699) * chore(cloudconfig): Decouple cloud config refresh interval from cache refresh interval * fix(cloudconfig): fix annotations per scott fredrick * fix(cloudconfig): add EnableConfigProperties to CloudConfigRefreshConfig class per feedback * refactor(cloud config): Adjusted based on feedback from Nicolas and Scott Frederick * refactor(cloudconfig): remove AutoConfigure annotation for RedisConfig as it's no longer used. * refactor(cloudconfig): Removed default as a default now exists in property file Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: root <root@a8f3fe14fb2c>
This commit fixes a broken link to the documentation on how to submit a patch.
Co-authored-by: Zach Smith <zachsmith@Zachs-MBP-2.attlocal.net>
* chore(ecs): Refactor TaskHealthCachingAgent networking check * moving taskDef null check closer to usage
…fter a refresh (#4716) * fix(kubernetes): Tests for dynamic accounts caching agents * fix(kubernetes): Add instead of overwrite agents for modified accounts * fix(kubernetes): Don't delete agents on errors building new ones * fix(kubernetes): Renamed staged agents variable removed copy
…/requestId (#4921) This addresses an issue when a task consists of multiple saga actions. ``` [ { "destroyServerGroup": { ... } }, { "destroyServerGroup": { ... } } ] ```
…#4773) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This artifact represented a proof-of-concept that we did not end up moving forward on.
Co-authored-by: root <root@3d7a4776ad28>
…4907) * feat(credentials): AccountCredentials as kork/Credentials - Add providers migrated to a kork/Credentials repository to the DefaultAccountCredentialsProvider * bump build * feat(credentials): Use proper exception and not nullable result * feat(credentials): fix test * feat(credentials): per component object mapper * feat(credentials): move dependency to kork-credentials-api in clouddriver-api
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…4933) * fix(titus): Update Kato task status to surface better error message * minor fix
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…ionProcessor to provide custom user messages on exceptions (#4929) * feat(extensibility): Use ExceptionSummaryService in DefaultOrchestrationProcessor to provide custom user messages on exceptions * fix(plugins): Bump korkVersion * fix(plugins): Bump korkVersion
…ice (#4942) The EurekaProviderConfiguration does some manual ConfigurationProperties binding to allow eureka configuration to behave differently than standard rest clients without polluting the application context with extra OkHttpClientProperties beans. This was failing if multiple ConfigurationService beans were present. We don't actually need any ConfigurationService beans to successfully bind this configuration anyway, so this change just removes the autowiring.
…ndency (#4941) This extracts the configuration that sets up and uses spring-cloud-config-server into a separate module which then comes in as a runtimeOnly dependency in clouddriver-web. This makes config server an excludable dependency when you have some other way of getting dynamic configuration. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: root <root@bcaea77c9d18> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: root <root@96ca2b2c6285>
…4952) Co-authored-by: smaniyedath <shyam_maniyedath@intuit.com>
…oncurrency (#4950) Co-authored-by: smaniyedath <shyam_maniyedath@intuit.com>
… provider (#4930) * feat(kubernetes/credentials): Use kork-credentials for the Kubernetes provider - Use CredentialsRepository: this lets us be type safe. We can now define new credential sources or hook into the lifecycle of a credentials. - Move deploy manifest and health check tests from Groovy to Java - CredentialsInitializerSynchronizable is now just running a poller. - Use BaseProvider and avoid static calls to ProviderUtils * feat(credentials): converted resolver * feat(credentials): fix resolver test * Update clouddriver-kubernetes/src/main/java/com/netflix/spinnaker/clouddriver/kubernetes/health/KubernetesHealthIndicator.java Co-authored-by: Eric Zimanyi <ezimanyi@google.com> * feat(credentials): final, private Co-authored-by: Eric Zimanyi <ezimanyi@google.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…bda aliases (#4956) Co-authored-by: smaniyedath <shyam_maniyedath@intuit.com>
- made flag to consider app:account:test - added an exclude list for apps Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* avoid the (probably accidental) bitwise xor in Thread.sleep * in fact, don't call Thread.sleep at all, this is in a retry block * we don't need no retryCount, retries are handled by RetrySupport * rely on SpinnakerException with setRetryable(false) to stop retries Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: root <root@82abca9e29b6> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* feat(cloudfoundry): Migrate to kork-credentials * feat(credentials): Remove AccountCredentialsProvider * feat(credentials): Use proper exception and not nullable result Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* chore(titus): Remove V1 cache schema support * chore(titus): Remove non-streaming caching agents * chore(titus): Remove unused configuration flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:
Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.