Switch to default export from the module

vasturiano · Dec 13, 2024 · 560a228 · 560a228
1 parent 1dc0eaf
commit 560a228
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 14 deletions.
diff --git a/README.md b/README.md
@@ -18,7 +18,7 @@ Examples:
 ## Quick start
 
 ```js
-import { ConicPolygonGeometry } from 'three-conic-polygon-geometry';
+import ConicPolygonGeometry from 'three-conic-polygon-geometry';
 ```
 or using a *script* tag
 ```html
@@ -27,7 +27,7 @@ or using a *script* tag
 then
 ```js
 const myMesh = new THREE.Mesh(
-  new THREE.ConicPolygonGeometry(polygonGeoJson),
+  new ConicPolygonGeometry(polygonGeoJson),
   new THREE.MeshBasicMaterial({ color: 'blue' })
 );
 

diff --git a/example/countries-gdp-per-capita/index.html b/example/countries-gdp-per-capita/index.html
@@ -6,15 +6,15 @@
     "three/addons/": "https://esm.sh/three/examples/jsm/"
   }}</script>
 
-  <script type="module">import * as THREE from 'three'; window.THREE = { ...THREE };</script>
-  <script src="//unpkg.com/three-conic-polygon-geometry" defer></script>
-  <!--  <script src="../../dist/three-conic-polygon-geometry.js" defer></script>-->
+<!--  <script type="module">import * as THREE from 'three'; window.THREE = THREE;</script>-->
+<!--  <script src="../../dist/three-conic-polygon-geometry.js" defer></script>-->
 </head>
 
 <body>
 <div id="viz"></div>
 
 <script type="module">
+  import ConicPolygonGeometry from 'https://esm.sh/three-conic-polygon-geometry?external=three';
   import { TrackballControls } from 'three/addons/controls/TrackballControls.js?external=three';
 
   fetch('../geojson/ne_110m_admin_0_countries.geojson').then(res => res.json()).then(countries =>
@@ -33,7 +33,7 @@
       polygons.forEach(coords => {
         polygonMeshes.push(
           new THREE.Mesh(
-            new THREE.ConicPolygonGeometry(coords, 0, alt),
+            new ConicPolygonGeometry(coords, 0, alt),
             materials
           )
         );

diff --git a/example/countries/index.html b/example/countries/index.html
@@ -6,15 +6,15 @@
     "three/addons/": "https://esm.sh/three/examples/jsm/"
   }}</script>
 
-  <script type="module">import * as THREE from 'three'; window.THREE = { ...THREE };</script>
-  <script src="//unpkg.com/three-conic-polygon-geometry" defer></script>
+<!--  <script type="module">import * as THREE from 'three'; window.THREE = THREE;</script>-->
 <!--  <script src="../../dist/three-conic-polygon-geometry.js" defer></script>-->
 </head>
 
 <body>
 <div id="viz"></div>
 
 <script type="module">
+  import ConicPolygonGeometry from 'https://esm.sh/three-conic-polygon-geometry?external=three';
   import { TrackballControls } from 'three/addons/controls/TrackballControls.js?external=three';
 
   fetch('../geojson/ne_110m_admin_0_countries.geojson').then(res => res.json()).then(countries =>
@@ -33,7 +33,7 @@
       polygons.forEach(coords => {
         polygonMeshes.push(
           new THREE.Mesh(
-            new THREE.ConicPolygonGeometry(coords, alt / 10, alt, true, true, true, 1),
+            new ConicPolygonGeometry(coords, alt / 10, alt, true, true, true, 1),
             materials
           )
         );

diff --git a/rollup.config.js b/rollup.config.js
@@ -9,8 +9,7 @@ const { name, homepage, version, dependencies, peerDependencies } = pkg;
 
 const umdConf = {
   format: 'umd',
-  extend: true,
-  name: 'THREE',
+  name: 'ConicPolygonGeometry',
   globals: { three: 'THREE' },
   banner: `// Version ${version} ${name} - ${homepage}`
 };

diff --git a/src/index.js b/src/index.js
@@ -18,11 +18,11 @@ import geoPolygonTriangulate from './geoPolygonTriangulate';
 // support both modes for backwards threejs compatibility
 const setAttributeFn = new THREE.BufferGeometry().setAttribute ? 'setAttribute' : 'addAttribute';
 
-class ConicPolygonBufferGeometry extends THREE.BufferGeometry {
+class ConicPolygonGeometry extends THREE.BufferGeometry {
   constructor(polygonGeoJson, startHeight, endHeight, closedBottom, closedTop, includeSides, curvatureResolution) {
     super();
 
-    this.type = 'ConicPolygonBufferGeometry';
+    this.type = 'ConicPolygonGeometry';
 
     this.parameters = {
       polygonGeoJson,
@@ -139,4 +139,4 @@ function polar2Cartesian(lat, lng, r = 0) {
   ];
 }
 
-export { ConicPolygonBufferGeometry, ConicPolygonBufferGeometry as ConicPolygonGeometry };
+export default ConicPolygonGeometry;