Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting rollingUpdate gives "cannot read properties of undefined (reading 'sort')" error #6170

Closed
NielsH opened this issue Apr 1, 2022 · 4 comments · Fixed by #6186
Closed

Comments

@NielsH
Copy link

NielsH commented Apr 1, 2022

Describe the bug

We have a few pools where we waited for the new XOA release in order to use the rolling pool update feature with the update of 8.2.0 -> 8.2.1 due to the possibility of VMs failing to migrate with the old XOA version.
Just updated XOA to 5.69.1.
Now when we start the update we get an error in the logs and the update does not start:

pool.rollingUpdate
{
  "pool": "a238db7e-4618-9287-6a81-75b5710cf74d"
}
{
  "message": "Cannot read properties of undefined (reading 'sort')",
  "name": "TypeError",
  "stack": "TypeError: Cannot read properties of undefined (reading 'sort')
    at Xapi._xcpUpdate (file:///usr/local/lib/node_modules/xo-server/src/xapi/mixins/patching.mjs:313:19)
    at Xapi.installPatches (file:///usr/local/lib/node_modules/xo-server/src/xapi/mixins/patching.mjs:453:19)
    at Xapi.rollingPoolUpdate (file:///usr/local/lib/node_modules/xo-server/src/xapi/mixins/patching.mjs:506:16)
    at Object.<anonymous> (file:///usr/local/lib/node_modules/xo-server/src/api/pool.mjs:171:3)
    at Api.callApiMethod (file:///usr/local/lib/node_modules/xo-server/src/xo-mixins/api.mjs:314:20)"
}

To Reproduce
Steps to reproduce the behavior:

  1. Go to the pool
  2. Click Patches
  3. Click Rolling Pool Update
  4. Click OK to start

Expected behavior
A clear and concise description of what you expected to happen.

Rolling Pool update does its thing :)

However, an error occurs and its details are visible under <XOA_URL>/#/settings/logs

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • XOA (Appliance, not XO) on latest release channel. Version 5.69.1.
  • hypervisor: XCP-ng 8.2.0

Additional context
Add any other context about the problem here.

@olivierlambert
Copy link
Member

Thanks for the report @NielsH

I'm assigning @pdonias

@rauly1994
Copy link

rauly1994 commented Apr 5, 2022

hi, i'm going thru the same issue.

pool.installPatches
{
  "pool": "41cd79cb-63a3-8d12-59ea-1d28fe20e5f8"
}
{
  "message": "Cannot read property 'sort' of undefined",
  "name": "TypeError",
  "stack": "TypeError: Cannot read property 'sort' of undefined
    at Xapi._xcpUpdate (file:///opt/xo/xo-builds/xen-orchestra-202204020159/packages/xo-server/src/xapi/mixins/patching.mjs:313:19)
    at Xapi.installPatches (file:///opt/xo/xo-builds/xen-orchestra-202204020159/packages/xo-server/src/xapi/mixins/patching.mjs:453:19)
    at Object.call (file:///opt/xo/xo-builds/xen-orchestra-202204020159/packages/xo-server/src/api/pool.mjs:141:14)
    at Api.callApiMethod (file:///opt/xo/xo-builds/xen-orchestra-202204020159/packages/xo-server/src/xo-mixins/api.mjs:314:33)"
} 

@olivierlambert
Copy link
Member

We are working on it.

@olivierlambert
Copy link
Member

On people who reported or confirmed the issue: if you can, next time, please open a support ticket. We might miss/forgot issues sometimes on here (to be sure it won't happen again, I added a severity label on this one). Our internal ticket tracking is far more reliable to treat issues like this faster than here!

Thanks again for the report, I promise we'll fix it ASAP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants