Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/jobs): add button to copy jobs IDs #5951

Merged
merged 4 commits into from
Oct 15, 2021
Merged

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Oct 15, 2021

Adding possibility to copy job ID, to reuse it on the job job.runSequence

Screenshot

Capture d’écran de 2021-10-15 14-02-21

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA self-assigned this Oct 15, 2021
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain why we're adding this in the PR description.

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/jobs/new/index.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias October 15, 2021 12:03
packages/xo-web/src/xo-app/jobs/new/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/jobs/new/index.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias October 15, 2021 12:18
@pdonias pdonias changed the title feat(xo-web/jobs): add button to copy jobs id feat(xo-web/jobs): add button to copy jobs IDs Oct 15, 2021
@pdonias pdonias merged commit 9ceba1d into master Oct 15, 2021
@pdonias pdonias deleted the mathieu-clipboardJobid branch October 15, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants