fix(backups) #6091
Closed
fix(backups) #6091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-f
reviewed
Jan 15, 2022
packages/vhd-lib/Vhd/VhdDirectory.js
Outdated
| @@ -174,6 +174,9 @@ exports.VhdDirectory = class VhdDirectory extends VhdAbstract { | |||
|
|
|||
| async readHeaderAndFooter() { | |||
| let bufHeader, bufFooter | |||
| try { | |||
| await this.#readChunkFilters() | |||
| }catch(e){} | |||
There was a problem hiding this comment.
Do we need to do a patch release?
julien-f
reviewed
Jan 17, 2022
| const {isVhdAlias, resolveAlias} = require('./_resolveAlias') | ||
| exports.isVhdAlias = isVhdAlias | ||
| exports.resolveAlias = resolveAlias |
There was a problem hiding this comment.
I believe we should eventually remove this index in favor of specific submodule exports/imports.
Example for this commit:
import { isVhdAlias, resolveAlias } from 'vhd-lib//aliases.js'
fbeauchamp
force-pushed
the
nighlty-s3-checkAliases
branch
from
0572d28 to
3111a04
Compare
|
Please rebase on |
julien-f
force-pushed
the
nighlty-s3-checkAliases
branch
from
3fe00cd to
0eb1b91
Compare
|
DId it for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list
Fixes #007orSee xoa-support#42)CHANGELOG.unreleased.md:${name} v${new version})cron/parse.spec.js)xo-serverAPI changes, the corresponding test has been added to/updated onxo-server-testProcess
WiP:(Work in Progress) if not ready to be mergedFrom the Four Agreements: