Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backups): task warning if beforeBackup or checkBaseVdis steps fail #6266

Merged
merged 4 commits into from
Jun 9, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Jun 3, 2022

screenshot

image

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp force-pushed the fix_show_warning_when_callwriter_fail branch from dd746a6 to 15b2ecf Compare June 3, 2022 08:56
@fbeauchamp fbeauchamp force-pushed the fix_show_warning_when_callwriter_fail branch from 15b2ecf to 8b11f67 Compare June 7, 2022 08:03
@fbeauchamp fbeauchamp marked this pull request as ready for review June 7, 2022 08:10
@fbeauchamp fbeauchamp requested a review from julien-f June 7, 2022 08:10
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
@julien-f julien-f changed the title Fix(Backup): show a warning in the task log if a writer fails, an error if they all fails fix(backup): task warning if beforeBackup or checkBaseVdis steps fail Jun 9, 2022
@julien-f julien-f changed the title fix(backup): task warning if beforeBackup or checkBaseVdis steps fail fix(backups): task warning if beforeBackup or checkBaseVdis steps fail Jun 9, 2022
@julien-f julien-f merged commit c0d587f into master Jun 9, 2022
@julien-f julien-f deleted the fix_show_warning_when_callwriter_fail branch June 9, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants