Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/user): user tokens management through XO interface #6276

Merged
merged 28 commits into from
Jun 28, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Jun 9, 2022

Screenshot

Peek 17-06-2022 11-09

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@julien-f
Copy link
Member

julien-f commented Jun 9, 2022

  • creation column
  • token should be copiable
  • use <pre> to display token
  • use EditableText for description
  • create_at can be undefined
  • description can be undefined

Questions

  • should we make the expiration editable?
  • is the date format appropriate for use in a table?
    • it is large and not visibly comparable
    • how about ISO 8601 instead?

@MathieuRA MathieuRA requested a review from fbeauchamp June 9, 2022 13:20
@MathieuRA MathieuRA force-pushed the web_auth_token_crud branch from b682b3f to e737ec5 Compare June 10, 2022 09:37
@MathieuRA MathieuRA self-assigned this Jun 10, 2022
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/user/index.js Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from fbeauchamp June 15, 2022 08:46
@MathieuRA MathieuRA requested a review from pdonias June 15, 2022 08:51
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias June 17, 2022 09:12
@julien-f julien-f force-pushed the web_auth_token_crud branch from 63eeaaa to 174be3c Compare June 18, 2022 12:10
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/user/index.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias June 21, 2022 13:10
@pdonias pdonias changed the title feat(xo-web/user): user tokens management throught xo interface feat(xo-web/user): user tokens management through XO interface Jun 22, 2022
@MathieuRA MathieuRA removed the request for review from pdonias June 22, 2022 11:51
@MathieuRA MathieuRA requested a review from pdonias June 22, 2022 12:59
packages/xo-web/src/xo-app/user/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/user/index.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias June 28, 2022 12:36
@pdonias pdonias merged commit c7df11c into master Jun 28, 2022
@pdonias pdonias deleted the web_auth_token_crud branch June 28, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants