Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server/xo-web/health): detect invalid vhd-parent VDIs #6356

Merged
merged 11 commits into from
Aug 31, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Aug 5, 2022

Screenshot

Capture d’écran de 2022-08-23 16-30-57

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA
Copy link
Member Author

@julien-f Is that what you expected?
I don't have the possibility to test, I'm not sure that it treats the problem as you wanted.

@MathieuRA MathieuRA changed the title Wip: detect missing vhd-parent VDIs Wip: feat(xo-server/xo-web/health)detect missing vhd-parent VDIs Aug 5, 2022
@MathieuRA MathieuRA changed the title Wip: feat(xo-server/xo-web/health)detect missing vhd-parent VDIs Wip: feat(xo-server/xo-web/health): detect missing vhd-parent VDIs Aug 5, 2022
@MathieuRA MathieuRA self-assigned this Aug 11, 2022
@MathieuRA MathieuRA changed the title Wip: feat(xo-server/xo-web/health): detect missing vhd-parent VDIs feat(xo-server/xo-web/health): detect missing vhd-parent VDIs Aug 12, 2022
@MathieuRA MathieuRA changed the title feat(xo-server/xo-web/health): detect missing vhd-parent VDIs feat(xo-server/xo-web/health): detect invalid vhd-parent VDIs Aug 12, 2022
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI self-requested a review August 26, 2022 12:40
@pdonias pdonias requested a review from julien-f August 29, 2022 13:07
@julien-f julien-f merged commit a9c1239 into master Aug 31, 2022
@julien-f julien-f deleted the missing-vdi branch August 31, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants