Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server): handle unfetched VDIs in pool.$ha_statefiles #6404

Merged
merged 6 commits into from
Sep 6, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Sep 5, 2022

introduced by #6384

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA requested a review from fbeauchamp September 5, 2022 11:16
@MathieuRA MathieuRA self-assigned this Sep 5, 2022
@MathieuRA MathieuRA requested a review from julien-f September 6, 2022 07:17
@julien-f julien-f changed the title fix(xo-server): cannot read properties of undefined (reading 'haSrs') fix(xo-server): handle unfetched VDIs in pool.$ha_statefiles Sep 6, 2022
MathieuRA and others added 2 commits September 6, 2022 11:28
@@ -12,6 +12,7 @@
> Users must be able to say: “I had this issue, happy to know it's fixed”

- [Plugin/auth-saml] Certificate input support multiline (PR [#6403](https://github.com/vatesfr/xen-orchestra/pull/6403))
- [Storage/Pool] Fix `an error as occured` (PR [#6404](https://github.com/vatesfr/xen-orchestra/pull/6404))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does Storage/Pool mean?

@julien-f julien-f merged commit 2371109 into master Sep 6, 2022
@julien-f julien-f deleted the fixIsHa branch September 6, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants