Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/pool): XCP-ng license binding #6453

Merged
merged 12 commits into from
Oct 28, 2022
Merged

feat(xo-web/pool): XCP-ng license binding #6453

merged 12 commits into from
Oct 28, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Oct 7, 2022

See gitlab-xoa#59

Manual test

- bind license. OK
- Rebind license. OK
- Rebind license of unknown host. OK
- Rebind/Bind license on xcp-ng < 7.6 OK
- Button disabled for no xcp-ng host. OK
- Button disabled for host fully supported. OK
- If several licenses for one host, no error triggered. OK
- Rebind a license that is used in an host with several licenses. host still under license. OK
- User admin on a pool, but non admin of XOA should not see licenses information. OK

Screenshot

Capture d’écran de 2022-10-28 17-38-48
Capture d’écran de 2022-10-28 17-36-52
Capture d’écran de 2022-10-28 17-42-48
Capture d’écran de 2022-10-28 17-43-13
Capture d’écran de 2022-10-28 17-44-04

GIF

Peek 28-10-2022 14-41

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@julien-f julien-f changed the title Wip: feat(xo-web/pool): binding xpc-ng licenses Wip: feat(xo-web/pool): binding xcp-ng licenses Oct 7, 2022
@MathieuRA MathieuRA self-assigned this Oct 12, 2022
@MathieuRA MathieuRA changed the title Wip: feat(xo-web/pool): binding xcp-ng licenses feat(xo-web/pool): binding xcp-ng licenses Oct 13, 2022
@MathieuRA MathieuRA force-pushed the mathieu/hostLicense branch from 069e535 to 6edfc26 Compare October 14, 2022 08:50
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/render-xo-item.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/select-objects.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/select-objects.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/home/pool-item.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/select-license.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/select-license.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/select-license.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/xoa/licenses/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/xoa/licenses/index.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/home/pool-item.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/index.js Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/select-license.js Outdated Show resolved Hide resolved
packages/xo-web/src/icons.scss Outdated Show resolved Hide resolved
@MathieuRA MathieuRA force-pushed the mathieu/hostLicense branch from da9e780 to 96c6f85 Compare October 28, 2022 13:40
@MathieuRA MathieuRA requested review from pdonias and removed request for Rajaa-BARHTAOUI October 28, 2022 13:42
@pdonias pdonias changed the title feat(xo-web/pool): binding xcp-ng licenses feat(xo-web/pool): XCP-ng license binding Oct 28, 2022
@pdonias pdonias merged commit 1269ddf into master Oct 28, 2022
@pdonias pdonias deleted the mathieu/hostLicense branch October 28, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants