Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-server): implement warm migration backend #6549

Merged
merged 2 commits into from
Nov 28, 2022
Merged

feat(xo-server): implement warm migration backend #6549

merged 2 commits into from
Nov 28, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Nov 24, 2022 •
edited
Loading

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp force-pushed the feat_warm_transfer branch 6 times, most recently from b5d8b4b to 0e0a18c Compare November 24, 2022 13:07
@fbeauchamp fbeauchamp requested a review from julien-f November 24, 2022 13:09
@julien-f julien-f changed the title Feat(xo-server): implement lukewarm migration backend feat(xo-server): implement warm migration backend Nov 24, 2022
julien-f
julien-f reviewed Nov 24, 2022
View reviewed changes
packages/xo-server/src/api/vm.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/migrate-vm.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/migrate-vm.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/api/vm.mjs Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp marked this pull request as ready for review November 25, 2022 07:48
@MathieuRA MathieuRA mentioned this pull request Nov 25, 2022
Merged
8 tasks
@fbeauchamp fbeauchamp requested a review from julien-f November 28, 2022 09:31
@julien-f julien-f merged commit 72c69d7 into master Nov 28, 2022
@julien-f julien-f deleted the feat_warm_transfer branch November 28, 2022 16:28
pdonias pushed a commit that referenced this pull request Nov 29, 2022
@MathieuRA
feat(xo-web/VM/advanced): add button for warm migration (#6533)
f3a09f2 
See #6549
ByScripts pushed a commit that referenced this pull request Dec 14, 2022
@fbeauchamp @ByScripts
feat(xo-server): implement warm migration backend (#6549)
3411a18
ByScripts pushed a commit that referenced this pull request Dec 14, 2022
@MathieuRA @ByScripts
feat(xo-web/VM/advanced): add button for warm migration (#6533)
93f519b 
See #6549
@fbeauchamp fbeauchamp mentioned this pull request Mar 26, 2024
Merged
julien-f pushed a commit that referenced this pull request Mar 27, 2024
@fbeauchamp
fix(xo-server/warmMigration): feature is for sources and premium (#7514)
ed4e080 
Introduced by #6549 

See https://team.vates.fr/vates/pl/745krdomtff99rf8951p65rkxh

In the feature matrix of XO, warm migration is for premium (and sources) users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f Awaiting requested review from julien-f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbeauchamp @julien-f