-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More efficient reset of global dictionary #1107
Comments
Not doable because the global section can import modules etc. |
Okay ... but looks like some optimization can be done with the patch above -- it is the best we can do? One common scenario is that global section can have some large variables (that involves reading / parsing files on disk). Would be nice to be able to facilitate passing them around unless it is too costly to cache. |
For you particular workflow, the |
It is surprising that
takes |
I see ... thank you! I tend to do this a lot (not pre-computing path formats ...). Do you think there is a more principled way to do it? Also 1.1s is not too bad -- compared to the total 4min delay we are talking about in #1146 , right? |
On you machine it is about 5s for each I think the rest of the delay is for checking the existence of these files and build DAG etc. |
The problem is also that in many cases we evaluate global definition along with a user-passed dictionary, which makes caching results of global definition more difficult because user-passed dictionary is not hashable. |
Done by #1219 |
We many times need "clean" dictionaries for step analysis and execution of steps and we usually do
repeatedly.
It would be helpful to do this once, save the result to a global dictionary, and use that dictionary to populate
sos_dict
when needed.The problem here is that the dictionary would be effective in only one process so it is not that useful when processes are created and destroyed quickly.
The text was updated successfully, but these errors were encountered: