Try map failure #1924
Merged
Try map failure #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1924 +/- ##
============================================
+ Coverage 98.03% 98.03% +<.01%
- Complexity 5079 5082 +3
============================================
Files 89 89
Lines 11549 11553 +4
Branches 1521 1522 +1
============================================
+ Hits 11322 11326 +4
Misses 109 109
Partials 118 118
Continue to review full report at Codecov.
|
l0rinc
reviewed
Mar 24, 2017
| } | ||
| } | ||
|
|
||
| private static <T> Resource<T> resource(T value) { |
There was a problem hiding this comment.
It's just my preference: please consider renaming to Closeable or TestAutoCloseable or DummyCloseable etc and provide a static of factory, as done in other places.
| @@ -457,8 +457,8 @@ default T single() { | |||
| * Matches each element with a unique key that you extract from it. | |||
| * If the same key is present twice, the function will return {@code None}. | |||
| * | |||
| * @param classifier A function which extracts a key from elements | |||
| * @param <K> key class type | |||
| * @param getKey A function which extracts a key from elements | |||
|
Note: Calls to
Solution: make Try an abstract class (see #1825) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up of #1923