-
-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concurrent recursive function memoization #2096
Concurrent recursive function memoization #2096
Conversation
…ates daemon threads" This reverts commit c0a16a8.
Codecov Report
@@ Coverage Diff @@
## master #2096 +/- ##
============================================
- Coverage 97.49% 97.33% -0.17%
Complexity 5188 5188
============================================
Files 92 94 +2
Lines 11928 11948 +20
Branches 1575 1577 +2
============================================
Hits 11629 11629
- Misses 149 169 +20
Partials 150 150
Continue to review full report at Codecov.
|
Thank you, I will review it tomorrow! |
I will close the pull request from GitHub, because it does not compile anymore with the demise of Promise in #2093 |
Mmhh, sorry. I think it is still possible. The new Sorry for being so slow. There is so much to do - it will take some days until I'm able to check all PRs. Our blog will be deleted on Sep 30th because RedHat stops OpenShift v2. I'm currently creating a new blog on clever-cloud and migrating all the data. In parallel we urgently need a v0.9.2 because some nasty bugs where reported. Also we need to support JDK9. With four kids it is sometimes hard to find enough time beside the daylight job. Sorry for letting you down. One thing about the PR - I need to check how we could integrate the feature with Vavr. I do not want to create new (public visible) types, our goal is to keep the core lib as thin as possible. We will see... |
Don't worry, I'm not feeling let down at all. I appreciate all the hard work you're putting into this library. (Four kids - happy you. We were four at home as well.) |
Thx for the kind words |
Fixes #2086
Hi there, I've gone and created a pull request. Changes compared to the original proposal: MemoizedConcurrently has an additional method that accepts a cache implementation, and ConcurrentTrampoliningMemoizer is hidden (package private).
Regards,
Sebastian