Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed Checked* interfaces to declare to throw Exception instead of Throwable #2162

Conversation

nfekete
Copy link
Member

@nfekete nfekete commented Nov 9, 2017

also updated test code to reflect these changes

the changes are pretty straightforward and don't affect the behavior of vavr, only the API

would fix #2137

…Throwable

also updated test code to reflect these changes
@nfekete nfekete closed this Nov 10, 2017
@nfekete nfekete reopened this Nov 10, 2017
@codecov-io
Copy link

Codecov Report

Merging #2162 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2162   +/-   ##
=========================================
  Coverage     97.45%   97.45%           
  Complexity     5206     5206           
=========================================
  Files            92       92           
  Lines         11934    11934           
  Branches       1576     1576           
=========================================
  Hits          11630    11630           
  Misses          148      148           
  Partials        156      156
Impacted Files Coverage Δ Complexity Δ
vavr/src/main/java/io/vavr/CheckedConsumer.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...vr/src-gen/main/java/io/vavr/CheckedFunction1.java 96.77% <ø> (ø) 18 <0> (ø) ⬇️
vavr/src/main/java/io/vavr/CheckedPredicate.java 0% <ø> (ø) 1 <0> (ø) ⬇️
...vr/src-gen/main/java/io/vavr/CheckedFunction3.java 96.66% <ø> (ø) 14 <0> (ø) ⬇️
...vr/src-gen/main/java/io/vavr/CheckedFunction7.java 97.05% <ø> (ø) 14 <0> (ø) ⬇️
...vr/src-gen/main/java/io/vavr/CheckedFunction6.java 96.96% <ø> (ø) 14 <0> (ø) ⬇️
...vr/src-gen/main/java/io/vavr/CheckedFunction4.java 96.77% <ø> (ø) 14 <0> (ø) ⬇️
...vr/src-gen/main/java/io/vavr/CheckedFunction8.java 97.14% <ø> (ø) 14 <0> (ø) ⬇️
...vr/src-gen/main/java/io/vavr/CheckedFunction5.java 96.87% <ø> (ø) 14 <0> (ø) ⬇️
...vr/src-gen/main/java/io/vavr/CheckedFunction2.java 96.55% <ø> (ø) 15 <0> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0949a89...8e4675a. Read the comment docs.

Copy link
Contributor

@danieldietrich danieldietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the PR looks great!

@danieldietrich danieldietrich merged commit 9379fb2 into vavr-io:master Nov 14, 2017
@nfekete nfekete deleted the checked-interfaces-exception-instead-of-throwable branch November 14, 2017 22:52
danieldietrich pushed a commit that referenced this pull request Jan 13, 2019
…Throwable (#2162)

also updated test code to reflect these changes
danieldietrich pushed a commit that referenced this pull request Jan 13, 2019
…Throwable (#2162)

also updated test code to reflect these changes
danieldietrich pushed a commit that referenced this pull request Jan 16, 2019
…Throwable (#2162)

also updated test code to reflect these changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why are Checked* classes declared to throw Throwable
3 participants