Mark 'Case*' internal functions as 'transient' #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrnSaurabh
reviewed
Oct 4, 2024
| @@ -5123,7 +5123,7 @@ public static final class Case0<T, R> implements Case<T, R> { | |||
| private static final long serialVersionUID = 1L; | |||
|
|
|||
| private final Pattern0<T> pattern; | |||
| private final Function<? super T, ? extends R> f; | |||
| private final transient Function<? super T, ? extends R> f; | |||
There was a problem hiding this comment.
API is a generated class hence this change should be done in Generator class. I have taken care of this in my PR: https://github.com/vavr-io/vavr/pull/2880/files#diff-3b19b7314b0707a187940dc9e7f5bf8aa42e99ff0804aedae5e36eb9c764be3aR1107
KrnSaurabh
reviewed
Oct 4, 2024
| @@ -5169,7 +5169,7 @@ public static final class Case2<T, T1, T2, R> implements Case<T, R> { | |||
| private static final long serialVersionUID = 1L; | |||
|
|
|||
| private final Pattern2<T, T1, T2> pattern; | |||
| private final BiFunction<? super T1, ? super T2, ? extends R> f; | |||
| private final transient BiFunction<? super T1, ? super T2, ? extends R> f; | |||
There was a problem hiding this comment.
Same as above comment: https://github.com/vavr-io/vavr/pull/2873/files#r1787356341
KrnSaurabh
reviewed
Oct 4, 2024
| @@ -5146,7 +5146,7 @@ public static final class Case1<T, T1, R> implements Case<T, R> { | |||
| private static final long serialVersionUID = 1L; | |||
|
|
|||
| private final Pattern1<T, T1> pattern; | |||
| private final Function<? super T1, ? extends R> f; | |||
| private final transient Function<? super T1, ? extends R> f; | |||
There was a problem hiding this comment.
Same as above comment: https://github.com/vavr-io/vavr/pull/2873/files#r1787356341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.