Unleashed javaslang.collection.Iterator. Refactored Collections.

[danieldietrich]

• Fixes Implement Scala like Iterator with lazy map/flatMap capabilities #431 Implement Scala like Iterator with lazy map/flatMap capabilities
• Fixes Remove internal abstract classes from public API #291 Remove internal abstract classes from public API
• Fixes Re-organize collection.Tree #256 Re-organize collection.Tree
• Towards Make complex hashCodes lazy #433 Make complex hashCodes lazy // but Deserialization of transient Lazy does not work!
• Towards Make interface Tree extend Traversable #113 Make interface Tree extend Traversable
  • // it will at least extend Iterable and FilterMona, maybe TraversableOnce but not Traversable

[danieldietrich]

@ruslansennov I'm on vacation with my family for one week, starting tomorrow. Notebook has to stay home o_O... I will try to go online at most once a day. We will see.

[danieldietrich]

@ruslansennov I refactored the collections a little bit. Please have a look (HashSet, HashMap). There is now javaslang.collection.Iterator...

[ruslansennov]

Have a nice trip! It's a good idea to leave the laptop at home

[danieldietrich]

Yes...

[danieldietrich]

I made HAMT and Interface. That leaks the inner classes to the public.

Pro: this enables pattern matching by subtype, 'introspection' and Proxying of the HAMT.

Con: the public API shows more classes

I'm not sure. We can switch back, when in doubt. The RedBlackTree is also designed as Interface with inner static classes. I like interfaces in general. They are more flexible, and it seems a good design practice to me.

[ruslansennov]

Con: the public API shows more classes

This was the reason I chose abstract class instead of interface
But there is not problem, I believe it's just a matter of taste

[danieldietrich]

Ok. Abstract classes were always some intermediate types to me, not intended to be directly used other than extending them for own types. We will go with interfaces for now. I hope that Java 9 gives us some extra syntax regarding interfaces to hide private methods and maybe private inner classes. We will see.