Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added eslint-plugin-import #600

Merged
merged 4 commits into from
Sep 19, 2019
Merged

Added eslint-plugin-import #600

merged 4 commits into from
Sep 19, 2019

Conversation

radekmie
Copy link
Contributor

@radekmie radekmie commented Sep 18, 2019

Finally, imports will be at least partially organized. Sorting is not yet possible: import-js/eslint-plugin-import#389.

EDIT: I've sorted them semi-automatically using renke/import-sort.

@radekmie radekmie added the Type: Feature New features and feature requests label Sep 18, 2019
@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #600 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         163      163           
  Lines        1533     1533           
  Branches       12       12           
=======================================
  Hits         1531     1531           
  Partials        2        2
Impacted Files Coverage Δ
packages/uniforms-material/src/ListField.js 100% <ø> (ø) ⬆️
packages/uniforms-bootstrap3/src/QuickForm.js 100% <ø> (ø) ⬆️
packages/uniforms-bootstrap4/src/ListField.js 100% <ø> (ø) ⬆️
packages/uniforms-semantic/src/AutoField.js 100% <ø> (ø) ⬆️
packages/uniforms-antd/src/QuickForm.js 100% <ø> (ø) ⬆️
packages/uniforms-bootstrap4/src/AutoField.js 100% <ø> (ø) ⬆️
packages/uniforms-unstyled/src/ListField.js 100% <ø> (ø) ⬆️
packages/uniforms-antd/src/AutoField.js 100% <ø> (ø) ⬆️
...niforms-bridge-json-schema/src/JSONSchemaBridge.js 100% <ø> (ø) ⬆️
packages/uniforms-bootstrap3/src/ListField.js 100% <ø> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d86d2b0...0f97866. Read the comment docs.

@radekmie
Copy link
Contributor Author

Reference order should be like this:

// No bindings.
import 'path';
// Namespaces.
import * as X 'path';
import * as Y 'path';
import * as z 'path';
// Default imports (and optional named).
import A from 'path';
import B, { Any1, any1, b1 } from 'path';
import C from 'path';
import a from 'path';
import b, { Any2, any2, b2 } from 'path';
// Only named.
import { C, D } from 'path';
import { E } from 'path';
import { e, f } from 'path';
import { g } from 'path';

@radekmie radekmie merged commit 87da4e9 into master Sep 19, 2019
@radekmie radekmie deleted the add-eslint-imports branch September 19, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants