Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(widget): Simplify code, update dependencies, and add debug validation #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DarkMarksDoe
Copy link

  • Remove Container widgets and use SizedBox.shrink instead
  • Remove print statements and add kDebug validation
  • Add print lints
  • Update packages and versions
  • Add required parameters to constructor

…alidation

- Remove Container widgets and use SizedBox.shrink instead
- Remove print statements and add kDebug validation
- Add print lints
- Update packages and versions
- Add required parameters to constructor
@vbalagovic
Copy link
Owner

@DarkMarksDoe Hi, thanks for the PR! Before merging, I need to check if this works on an older version than 3.7. Because I wanted to fix the pub score too and removed null checkers but then it didn't work on 3.3.10

@DarkMarksDoe
Copy link
Author

@vbalagovic Hi!
If you need some help for documentation, tests, changes let me know, this widget has the potential to be scalable.
Greetings from Mexico! 🇲🇽

@vbalagovic
Copy link
Owner

@vbalagovic Hi!
If you need some help for documentation, tests, changes let me know, this widget has the potential to be scalable.
Greetings from Mexico! 🇲🇽

Thanks so much! I’ve organised Zagorje DevCon this weekend so I was off, but I hope we’ll collaborate on this :)

greeting from Croatia :))

@vbalagovic
Copy link
Owner

vbalagovic commented Mar 1, 2023

@DarkMarksDoe Sorry, I didn't have time to review this sooner, I see the same issue that I had with the flutter 3.3.10 version, honestly, I would like it to still work on at least 3.3... versions :/

`
fvm flutter run -d 7C9B6022-6840-4DFE-AB08-55E54B8787BB
Launching lib/main.dart on iPhone 14 in debug mode...
Running Xcode build...
Xcode build done. 6.5s
Failed to build iOS app
Error output from Xcode build:

** BUILD FAILED **

Xcode's output:

Writing result bundle at path:
/var/folders/3n/d0ycmrdn33s9_dvfmdg4tzwm0000gn/T/flutter_tools.rpIkhZ/flutter_ios_build_temp_dirD16Uia/temporary_xcresult_bundle

../lib/flutter_simple_multiselect.dart:347:38: Error: Property 'position' cannot be accessed on 'ScrollableState?' because it is potentially null.
 - 'ScrollableState' is from 'package:flutter/src/widgets/scrollable.dart' ('../../../fvm/versions/3.3.10/packages/flutter/lib/src/widgets/scrollable.dart').
Try accessing using ?. instead.
        await Scrollable.of(context).position.ensureVisible(renderBox);
                                     ^^^^^^^^
../lib/suggestions_box_controller.dart:18:25: Error: Method 'insert' cannot be called on 'OverlayState?' because it is potentially null.
 - 'OverlayState' is from 'package:flutter/src/widgets/overlay.dart' ('../../../fvm/versions/3.3.10/packages/flutter/lib/src/widgets/overlay.dart').
Try calling using ?. instead.
    Overlay.of(context).insert(overlayEntry!);
                        ^^^^^^
Failed to package /Users/vedran/Projects/flutter_simple_multiselect/example.
Command PhaseScriptExecution failed with a nonzero exit code
note: Building targets in dependency order
warning: Run script build phase 'Run Script' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'Runner' from project 'Runner')
warning: Run script build phase 'Thin Binary' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'Runner' from project 'Runner')

Result bundle written to path:
    /var/folders/3n/d0ycmrdn33s9_dvfmdg4tzwm0000gn/T/flutter_tools.rpIkhZ/flutter_ios_build_temp_dirD16Uia/temporary_xcresult_bundle

Could not build the application for the simulator.
Error launching application on iPhone 14.
`

@DarkMarksDoe
Copy link
Author

DarkMarksDoe commented Mar 3, 2023

@vbalagovic How many things de we have to do for migrating it?
We can work on it via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants