-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(widget): Simplify code, update dependencies, and add debug validation #1
base: main
Are you sure you want to change the base?
Conversation
DarkMarksDoe
commented
Feb 22, 2023
- Remove Container widgets and use SizedBox.shrink instead
- Remove print statements and add kDebug validation
- Add print lints
- Update packages and versions
- Add required parameters to constructor
…alidation - Remove Container widgets and use SizedBox.shrink instead - Remove print statements and add kDebug validation - Add print lints - Update packages and versions - Add required parameters to constructor
@DarkMarksDoe Hi, thanks for the PR! Before merging, I need to check if this works on an older version than 3.7. Because I wanted to fix the pub score too and removed null checkers but then it didn't work on 3.3.10 |
@vbalagovic Hi! |
Thanks so much! I’ve organised Zagorje DevCon this weekend so I was off, but I hope we’ll collaborate on this :) greeting from Croatia :)) |
@DarkMarksDoe Sorry, I didn't have time to review this sooner, I see the same issue that I had with the flutter 3.3.10 version, honestly, I would like it to still work on at least 3.3... versions :/ ` Xcode's output:
Could not build the application for the simulator. |
@vbalagovic How many things de we have to do for migrating it? |