This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
fix: the logo is show in the settings has no effect. close #214 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
左侧菜单混合模式下，Logo设置被禁用，但是Logo的Toggle状态会影响到左侧sidebar的logo，跟vben2不一致。
这个跟 #214 无关，我拿到这里讨论下，可以的话一个PR处理掉 |
|
我认为更好的做法是: 切换到左侧菜单混合模式下,logo就变为打开状态无法关闭, 这样控制logo开关就光看一个属性，代码逻辑会更清晰些 |
又想了一下，有道理；打开状态应该只是显示的状态，不是内部实际的值吧 |
|
@likui628 这样耦合性低一些，只用在设置过程中就能处理好, 而不需要在logo组件内部进行过多的处理，没问题的话我改成这种 |
|
@likui628 改好了 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #214