-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue with vben/styles/global global injection #4106
Conversation
|
WalkthroughThe recent changes enhance the application's handling of file paths by improving the import statements and updating the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- internal/vite-config/src/config/application.ts (2 hunks)
Additional comments not posted (2)
internal/vite-config/src/config/application.ts (2)
5-5
: LGTM! Import statement enhancement.The inclusion of the full
path
module allows for better cross-platform compatibility by usingpath.sep
.
104-104
: LGTM! Improved path handling.Using
path.sep
ensures that the path check is reliable across different operating systems.
https://doc.vben.pro/guide/essentials/styles.html#bem-%E8%A7%84%E8%8C%83
在widow下无法注册成功
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yaml
unless you introduce a new test example.Checklist
pnpm run docs:dev
command.pnpm test
.feat:
,fix:
,perf:
,docs:
, orchore:
.Summary by CodeRabbit