fix: activePath not working in menu, fixed: #4112

[mynetfan]

Description

修复路由元数据中的activePath不起作用的问题。

该问题导致切换到使用了hideInMenu的路由时，混合菜单和和双列菜单会出现空白的现象。

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

• New Features
  • Improved the logic for determining the active menu item, making navigation more intuitive based on the current route context.
  • Enhanced the responsiveness of the menu to reflect the active path accurately upon route changes.

[changeset-bot]

⚠️ No Changeset found

Latest commit: cac7d97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The recent updates enhance the logic of determining the active menu item in the application. By prioritizing route.meta?.activePath, the code offers a more relevant routing context across multiple components, ensuring that the UI reflects the current state of navigation more accurately. This improves user experience by providing clear indicators of active paths within the menu system.

Changes

Files	Change Summary
packages/effects/layouts/src/basic/menu/extra-menu.vue packages/effects/layouts/src/basic/menu/use-extra-menu.ts packages/effects/layouts/src/basic/menu/use-mixed-menu.ts	Updated logic to prioritize route.meta?.activePath for determining the active path in menus, enhancing responsiveness to the current route.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Router
    participant MenuComponent

    User->>Router: Navigate to a route
    Router->>MenuComponent: Update route information
    MenuComponent->>MenuComponent: Check active path
    MenuComponent->>MenuComponent: Set active menu item based on `route.meta?.activePath`

Loading

Poem

🐇 In the meadow where menus play,
Active paths now lead the way!
With a hop and a skip, we find,
The right route for every kind.
A joyful dance, a clear delight,
Our navigation shines so bright! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ec49a04 and cac7d97.

Files selected for processing (3)

• packages/effects/layouts/src/basic/menu/extra-menu.vue (1 hunks)
• packages/effects/layouts/src/basic/menu/use-extra-menu.ts (1 hunks)
• packages/effects/layouts/src/basic/menu/use-mixed-menu.ts (1 hunks)

Additional comments not posted (3)

packages/effects/layouts/src/basic/menu/extra-menu.vue (1)

33-33: LGTM! Verify the impact on the UI.

The change to use route.meta?.activePath || route.path for default-active is a sound improvement. It allows for more flexible route handling. Ensure that this change does not introduce any unexpected behavior in the UI.

packages/effects/layouts/src/basic/menu/use-extra-menu.ts (1)

84-84: LGTM! Verify the impact on routing logic.

The change to use route.meta?.activePath || path for currentPath enhances the routing context. It should improve the handling of active paths. Ensure that this change does not introduce any unexpected behavior in the routing logic.

packages/effects/layouts/src/basic/menu/use-mixed-menu.ts (1)

116-116: LGTM! Verify the impact on side menu calculation.

The change to use route.meta?.activePath || route.path in calcSideMenus is a sound improvement. It should enhance the calculation of side menus. Ensure that this change does not introduce any unexpected behavior in the side menu logic.