fix(@vben/common-ui): text omission component expansion exception

[wangjue666]

Description

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• New Features

  • Improved handling of text expansion and tooltip visibility in the ellipsis-text component.

• Bug Fixes

  • Enhanced tests for the ellipsis-text component to ensure correct behavior of the expandChange event during user interactions.

• Refactor

  • Simplified logic for the tooltip and expansion functionalities, improving component efficiency and readability.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2702894

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The recent changes streamline the ellipsis-text.vue component and its associated tests, enhancing both functionality and test coverage. The logic for text expansion and tooltip visibility has been simplified by reducing reactive properties and directly linking tooltip behavior to the expansion state. Additionally, tests now thoroughly evaluate the emitted expandChange event, ensuring the component responds correctly to user interactions.

Changes

File Path	Change Summary
packages/effects/common-ui/src/components/ellipsis-text/__tests__/ellipsis-text.test.ts	Enhanced test coverage for ellipsis-text.vue, verifying expandChange event emissions on user interactions.
packages/effects/common-ui/src/components/ellipsis-text/ellipsis-text.vue	Simplified text expansion and tooltip logic, reducing reactive properties and improving readability of component flow.

Poem

In a meadow bright and wide,
A rabbit hops with joyful pride.
Changes made, oh what a sight!
Text expands and shines so bright.
With each click, a tale unfolds,
A dance of words, a joy retold! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 843ec1e and 2702894.

Files selected for processing (2)

• packages/effects/common-ui/src/components/ellipsis-text/tests/ellipsis-text.test.ts (1 hunks)
• packages/effects/common-ui/src/components/ellipsis-text/ellipsis-text.vue (5 hunks)

Additional comments not posted (7)

packages/effects/common-ui/src/components/ellipsis-text/__tests__/ellipsis-text.test.ts (1)

35-44: Enhanced test coverage for expandChange event.

The test now correctly verifies that the expandChange event is emitted with the expected values (true on first click and false on second click). This improvement ensures that the component behaves as expected during user interactions.

packages/effects/common-ui/src/components/ellipsis-text/ellipsis-text.vue (6)

2-2: Simplified imports and improved readability.

The imports are well-organized, and the use of ref and computed from Vue enhances the component's reactivity and readability.

---

76-78: Introduction of isExpand state for managing text expansion.

The isExpand state is now used to manage the text expansion logic, simplifying the component's control flow. This change improves the readability and maintainability of the code.

---

89-90: Streamlined onExpand function.

The onExpand function now directly toggles the isExpand state and emits the expandChange event. This simplification eliminates unnecessary complexity in the component's logic.

---

94-94: Improved conditional logic in handleExpand.

The handleExpand function now uses short-circuit evaluation to call onExpand only when props.expand is true. This enhances the readability and efficiency of the code.

---

106-106: Updated tooltip logic for better user experience.

The tooltip is now disabled when there is no tooltip text or when the text is expanded, aligning the tooltip behavior with user expectations and reducing unnecessary tooltip displays.

---

121-124: Dynamic styling for ellipsis element.

The ellipsis element's style is now dynamically adjusted based on the isExpand state, improving the component's responsiveness and visual consistency.