-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: element-plus styles #4203
fix: element-plus styles #4203
Conversation
closes #4201
|
WalkthroughThe recent changes enhance the styling capabilities of the application by introducing a new style module and expanding design tokens for colors. This results in improved visual fidelity and consistency across components, particularly the card design. The modifications align with user feedback on aesthetics and functionality, ensuring a better user experience. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- apps/web-ele/src/bootstrap.ts (1 hunks)
- packages/effects/hooks/src/use-design-tokens.ts (1 hunks)
- packages/styles/package.json (1 hunks)
- packages/styles/src/ele/index.css (1 hunks)
Files skipped from review due to trivial changes (2)
- apps/web-ele/src/bootstrap.ts
- packages/styles/src/ele/index.css
Additional comments not posted (2)
packages/styles/package.json (1)
21-23
: Addition of./ele
module is well-structured.The new entry for the
"./ele"
module follows the existing pattern and enhances the modularity of the style management system. This change looks good.packages/effects/hooks/src/use-design-tokens.ts (1)
183-225
: Expanded color palette enhances design flexibility.The expanded set of CSS variable assignments for color themes significantly improves the flexibility and customization of UI components. These changes align well with the objectives of enhancing visual fidelity.
Ensure that the
getCssVariableValue
function correctly retrieves the intended CSS variable values for all themes.
closes #4201
Description
element-plus css变量数字越大越浅,之前写反了
![image](https://private-user-images.githubusercontent.com/90845831/359497232-2369ceb3-b8eb-4170-9fc4-edea8f2d6930.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NjI1NzMsIm5iZiI6MTczODg2MjI3MywicGF0aCI6Ii85MDg0NTgzMS8zNTk0OTcyMzItMjM2OWNlYjMtYjhlYi00MTcwLTlmYzQtZWRlYThmMmQ2OTMwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE3MTc1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUyYTkwYjhkNmJhNjU4N2EzOTIxY2QwMzc4ZjI5ZGI0NWQzYzAxZTI1NTc1ZTMxYjQyOGI3MGQ0OGY5NjQzODAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.zM6O0kRzwv-p_0NJgvdR2WTu3kR8qcirrt2BoGqr_N0)
Type of change
Please delete options that are not relevant.
pnpm-lock.yaml
unless you introduce a new test example.Checklist
pnpm run docs:dev
command.pnpm test
.feat:
,fix:
,perf:
,docs:
, orchore:
.Summary by CodeRabbit
New Features
ele
module, enhancing style management.Improvements
Bug Fixes