fix(@vben/plugins/vxe-table): after resetting the search, the parameters still exist

[anncwb]

Description

fixed #4575

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• New Features

  • Enhanced form handling capabilities within the grid component, ensuring proper management of asynchronous operations during form resets.

• Bug Fixes

  • Improved initialization logic with warnings for unsupported form configurations.

• Chores

  • Updated the version of the vxe-pc-ui package to the latest version.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 53ada1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes in this pull request primarily focus on enhancing the form handling capabilities within the use-vxe-grid.vue component. Key modifications include updating the handleReset function to await the form reset operation, adjusting initialization logic to provide warnings regarding unsupported configurations, and incrementing the version of the vxe-pc-ui package in the pnpm-workspace.yaml file.

Changes

File	Change Summary
packages/effects/plugins/src/vxe-table/use-vxe-grid.vue	Updated handleReset to await formApi.resetForm(), modified initialization logic to warn about unsupported formConfig, and ensured tighter integration of computed properties with form handling.
pnpm-workspace.yaml	Updated vxe-pc-ui package version from ^4.2.13 to ^4.2.14.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure form reset does not use old values (#4575)	✅
Update dependencies as needed	✅

Possibly related PRs

• fix: the vxeUI global configuration does not take effect #4574: This PR modifies the use-vxe-grid.vue component to enhance the grid's configuration and initialization logic, which is directly related to the changes made in the main PR that also focuses on the use-vxe-grid.vue component's form handling and configuration.

Suggested reviewers

• vince292007

Poem

🐇 In the grid where forms do play,
A reset now won't lead astray.
With versions fresh and logic bright,
We hop along, all feels just right!
Let's celebrate this joyful change,
In our code, we’ll rearrange! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/effects/plugins/src/vxe-table/use-vxe-grid.vue (1)

Line range hint 145-150: Overall impact and suggestion for improvement

The change effectively addresses the issue without introducing significant alterations to the component's structure or logic. It's a focused fix that aligns well with the PR objectives and resolves the problem described in issue #4575.

To further enhance the robustness of this function, consider adding error handling:

handleReset: async () => {
  try {
    await formApi.resetForm();
    const formValues = formApi.form.values;
    props.api.reload(formValues);
  } catch (error) {
    console.error('Error resetting form:', error);
    // Optionally, you could add user feedback here
  }
},

This addition would ensure that any potential errors during the form reset process are caught and logged, improving the component's reliability and ease of debugging.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9ad4f96 and 53ada1b.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (2)

• packages/effects/plugins/src/vxe-table/use-vxe-grid.vue (1 hunks)
• pnpm-workspace.yaml (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• pnpm-workspace.yaml

🔇 Additional comments (1)

packages/effects/plugins/src/vxe-table/use-vxe-grid.vue (1)

146-146: Excellent fix for the search reset issue!

The addition of await before formApi.resetForm() is a crucial improvement. This change ensures that the form reset operation completes before retrieving the form values and reloading the grid. As a result, it effectively addresses the issue where old parameters were being sent in requests after resetting the search.

This modification:

1. Guarantees that formApi.form.values contains the reset values.
2. Aligns with best practices for handling asynchronous operations.
3. Provides a minimal and focused fix, reducing the risk of introducing new issues.

Great job on identifying and implementing this solution!