Skip to content

utils/file_io: fix double closing of ss::file in write_fully #1207

utils/file_io: fix double closing of ss::file in write_fully

utils/file_io: fix double closing of ss::file in write_fully #1207

Workflow file for this run

# Copyright 2020 Redpanda Data, Inc.
#
# Use of this software is governed by the Business Source License
# included in the file licenses/BSL.md
#
# As of the Change Date specified in that file, in accordance with
# the Business Source License, use of this software will be governed
# by the Apache License, Version 2.0
name: Lint all codez
on:
push:
branches:
- '**'
tags-ignore:
- '**'
pull_request:
branches:
- '**'
jobs:
go:
name: Lint go files
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Setup go
uses: actions/setup-go@v3
with:
go-version: stable
- name: Run golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.55.0
args: --timeout 5m
working-directory: src/go/rpk/
- name: Install gofumpt
env:
GOFUMPT_VER: 0.5.0
run: |
mkdir -v -p "$HOME/.local/bin"
wget -O "$HOME/.local/bin/gofumpt" "https://github.com/mvdan/gofumpt/releases/download/v${GOFUMPT_VER}/gofumpt_v${GOFUMPT_VER}_linux_amd64"
chmod 0700 "$HOME/.local/bin/gofumpt"
- name: Run gofumpt
run: |
find src/go -type f -not -name 'zz*' -name '*.go' | xargs -n1 "$HOME/.local/bin/gofumpt" -w -lang=1.20
git diff --exit-code
- name: go mod tidy (rpk)
working-directory: src/go/rpk
run: |
go mod tidy
git diff --exit-code -- go.mod go.sum
py:
name: Lint python files
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Install yapf
run: pip install yapf==0.40.1
- name: Run yapf
run: find . -type f -name '*.py' | xargs -n8 yapf -d
cpp:
name: Lint files with clang-format
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Run clang-format
run: |
docker run \
-v $PWD:/redpanda ubuntu:noble \
bash -c "cd /redpanda && \
apt update && \
apt install -y git clang-format-16 && \
find . -type f -regex '.*\.\(cpp\|h\|hpp\|cc\|proto\|java\)' | xargs -n1 clang-format-16 -i -style=file -fallback-style=none"
git diff --exit-code
sh:
name: Lint shell scripts
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Install shfmt
env:
SHFMT_VER: 3.6.0
run: |
mkdir -v -p "$HOME/.local/bin"
wget -O "$HOME/.local/bin/shfmt" "https://github.com/mvdan/sh/releases/download/v${SHFMT_VER}/shfmt_v${SHFMT_VER}_linux_amd64"
chmod 0700 "$HOME/.local/bin/shfmt"
- name: Run shfmt
run: shfmt -i 2 -ci -s -d .