Skip to content

Commit

Permalink
archival: Delete replaced segments during spillover GC
Browse files Browse the repository at this point in the history
Previously, if the spillover was enable we weren running normal GC
during the housekeeping run. Normal housekeeping is responsible for
removing segments evicted due to retention (which is not happening if
spillover region is not empty). But it also removes replaced segments.
So essentially, we have to run both types of GC on every spillover
housekeeping run.
  • Loading branch information
Lazin committed Jan 19, 2024
1 parent bfa1c9d commit 97f76de
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/v/archival/ntp_archiver_service.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2159,6 +2159,7 @@ ss::future<> ntp_archiver::housekeeping() {
} else {
co_await apply_archive_retention();
co_await garbage_collect_archive();
co_await garbage_collect();
}
co_await apply_spillover();
}
Expand Down

0 comments on commit 97f76de

Please sign in to comment.