Skip to content

Commit

Permalink
sagemathgh-38401: Fix a bug in version selector of documentation
Browse files Browse the repository at this point in the history
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

The version selector should work for

1. documentation in online sites
2. documentation in local sage install
3. standalone tree of the documentation (such as github action artifact
doc.zip)

The version selector javascript code works fine with the cases (1) and
(2), but currently it fails with (3).

Tested with doc.zip in
https://github.com/sagemath/sage/actions/runs/10032161715

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38401
Reported by: Kwankyu Lee
Reviewer(s): Matthias Köppe
  • Loading branch information
Release Manager committed Jul 24, 2024
2 parents 44f7dc9 + eae1b8b commit 274f476
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/doc/common/static/jupyter-sphinx-furo.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@ function changeVersion() {
if (selected_url) {
if (window.location.protocol == 'file:') {
let pathname = window.location.pathname;
let cutoff_point = pathname.indexOf('doc/sage');
let cutoff_point = pathname.indexOf('/html');
if (cutoff_point !== -1) {
pathname = pathname.substring(cutoff_point + 8);
pathname = pathname.substring(cutoff_point);
window.location.href = selected_url + pathname;
} else {
window.location.href = selected_url + 'html/en/index.html';
window.location.href = selected_url + '/index.html';
}
} else {
window.location.href = selected_url + window.location.pathname;
Expand Down

0 comments on commit 274f476

Please sign in to comment.