Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ASCII issue with compilation #96

Merged
merged 3 commits into from
Jan 17, 2021
Merged

Fix ASCII issue with compilation #96

merged 3 commits into from
Jan 17, 2021

Conversation

vishwakftw
Copy link
Collaborator

Addressing bug report:

  • A student uploaded a file that had emoticons and stuff in it. The file was Unicode. This caused a crash in a location where an exception was not even imagined to occur. So there was no exception caught.

@vishwakftw vishwakftw merged commit ddfb138 into master Jan 17, 2021
@vishwakftw vishwakftw deleted the bugfix/fix-ascii-issue branch January 17, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekkumarweb prateekkumarweb prateekkumarweb approved these changes

@vbsinha vbsinha Awaiting requested review from vbsinha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishwakftw @prateekkumarweb