Duplicate imports with different names in multiple files cause error #9
Comments
|
This is definitely an interesting issue that can point to the naming inconsistency in the original code. I think it is worth fixing, but it would be good to print a warning that two different names are used. |
Move all the business logic of parsing and generating code into maker subpackage. Instead of functions, the maker package exports a Maker struct, which has two exported methods: ParseSource to add a file, and MakeInterface to create the interface. The struct now handles the data that was previously handled by the main package between the invocation of the two functions. Don't use token.Pos to access source file byte array, this doesn't work when there are multiple files in the fileset. Use go/printer or directly get the parsed strings from the ast nodes. Ignore dot imports, assume they will not be needed by the generated struct. Throw errors when aliases conflict or a package is imported with different aliases (vburenin#9). Add a "Code generated by" comment per https://golang.org/s/generatedcode Add tests + travis.
Move all the business logic of parsing and generating code into maker subpackage. Instead of functions, the maker package exports a Maker struct, which has two exported methods: ParseSource to add a file, and MakeInterface to create the interface. The struct now handles the data that was previously handled by the main package between the invocation of the two functions. Don't use token.Pos to access source file byte array, this doesn't work when there are multiple files in the fileset. Use go/printer or directly get the parsed strings from the ast nodes. Ignore dot imports, assume they will not be needed by the generated struct. Throw errors when aliases conflict or a package is imported with different aliases (vburenin#9). Add a "Code generated by" comment per https://golang.org/s/generatedcode Add tests + travis.
|
I've implemented the warnings. It's possible to fix this properly (i.e. automatically generate a non-conflicting alias), but it's quite complicated. Since the package name doesn't have to be the same as the import path's last element, you have to find and parse imported packages to find out their actual package names, so that you can then find the |
|
That is definitely a lot of work. I would not go that far unless it is really needed. |
Move all the business logic of parsing and generating code into maker subpackage. Instead of functions, the maker package exports a Maker struct, which has two exported methods: ParseSource to add a file, and MakeInterface to create the interface. The struct now handles the data that was previously handled by the main package between the invocation of the two functions. Don't use token.Pos to access source file byte slice, this doesn't work when there are multiple files in the fileset. Use go/printer or directly get the parsed strings from the ast nodes. Ignore dot imports, assume they will not be needed by the generated struct. Throw errors when aliases conflict or a package is imported with different aliases (vburenin#9). Add a "Code generated by" comment per https://golang.org/s/generatedcode Add tests + travis.
Also ignore files that don't contain exported methods of the source struct, to avoid problems with imports (see vburenin#9). Fixes vburenin#3
|
I ran into this while fixing #3, but by just ignoring the files that don't contain methods, this error becomes much less likely to occur. I think it's reasonable to require those files to have consistent imports, and you get warnings if you make a mistake. That's a good enough solution for me. |
Also ignore files that don't contain exported methods of the source struct, to avoid problems with imports (see vburenin#9). Fixes vburenin#3
Move all the business logic of parsing and generating code into maker subpackage. Instead of functions, the maker package exports a Maker struct, which has two exported methods: ParseSource to add a file, and MakeInterface to create the interface. The struct now handles the data that was previously handled by the main package between the invocation of the two functions. Don't use token.Pos to access source file byte slice, this doesn't work when there are multiple files in the fileset. Use go/printer or directly get the parsed strings from the ast nodes. Ignore dot imports, assume they will not be needed by the generated struct. Throw errors when aliases conflict or a package is imported with different aliases (vburenin#9). Add a "Code generated by" comment per https://golang.org/s/generatedcode Add tests + travis.
Assuming you have these two files:
If you pass both files to ifacemaker, it will generate:
which is not valid because of the duplicate imports.
Similarly problematic are
pkg1 "github.com/user/pkg"+"github.com/user/pkg"and evenpkg "github.com/user/pkg"+"github.com/user/pkg".I'm not sure if it's worth fixing this. The hardest part is probably finding an alias that doesn't conflict, after that, aliasing everything should be easier.
The text was updated successfully, but these errors were encountered: