ylibvcs.git: Fix unbound local variable 'tag_sha' error #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes error like this one:
```
Traceback (most recent call last):
File "./extensions-index-checkout.py", line 150, in <module>
duration, result = timecall(repo.update_repo)()
File "./extensions-index-checkout.py", line 53, in wrapper
result = method(*args, **kwargs)
File "/home/jcfr/Projects/sandbox/libvcs/libvcs/git.py", line 198, in update_repo
self.debug("tag_sha: %s" % tag_sha)
UnboundLocalError: local variable 'tag_sha' referenced before assignment
```
Current coverage is 65.15%@@ master #11 diff @@
==========================================
Files 7 7
Lines 484 485 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 316 316
- Misses 168 169 +1
Partials 0 0
|
|
We need test coverage there bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes error like this one: