Prepare for Native AOT #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the goals (see #202) that I missed for the AST 5.0 release is that it was not publishable as a Native AOT application.
I ran in to a number of problems while investigating this that this PR intends to solve.
The new parser is not a drop in replacement. I made an effort to make sure the command line people are already using should remain valid, so it shouldn't break anyone. That said, the differences are big enough that there is likely a scenario or input that I have not tested. When we get closer to a v6.0 release, I intend to publish pre-release builds so that hopefully the community can test the new command line parser for compatibility breaks.
That said, after these changes, AzureSignTool can be built with zero trimming warnings or suppressions. The final AzureSignTool binary is 12.5 MB. I might be able to whittle it down a bit more, but considering that this has a whole bunch of the Azure SDK in it, I think it's a reasonable starting point and isn't big beyond usefulness.