Re-enable 32bit publishing for office VBA #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-enable 32bit Windows publishing needed for signing Office macros (OfficeSIPs are only available as 32bit). PublishAOT still available for 64-bit Windows publishing via build-condition.
vcsjones
approved these changes
Jun 22, 2024
|
Closed and re-opened because GitHub actions had a bad afternoon and needed to be re-run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling 32bit breaks Office-VBA signing
Keeping 32-bit support in place is crucial, while at the same time enable new 64-bit related features.
Re-enable 32bit Windows publishing needed for signing Office macros (OfficeSIPs needed for signing VBA in office files are only available as 32bit).
PublishAOT still available for 64-bit Windows publishing via build-condition.
This helps fixing problems as described in #126