fix(output-window): removes immediate setSize call (#849)

* fix(output-window): removes immediate setSize call

window timings are tricky, occasionally the setSize call sets width and height to 0

* feat(window): prevent accidental close or reload of output window

* fix: undo in-dev changes

src/application/window-handler.js

@@ -1,5 +1,6 @@
 export default function windowHandler() {
   const windows = {};
+  const that = this;
 
   function createHideMouseTimerhandler(canvas) {
     let mouseTimer;
@@ -18,10 +19,16 @@ export default function windowHandler() {
     };
   }
 
-  function configureWindow({ win, canvas, title, backgroundColor }) {
+  function configureWindow({ win, canvas, backgroundColor }) {
     win.document.body.appendChild(canvas);
-    win.document.title = title;
     win.document.body.style.backgroundColor = backgroundColor;
+    win.addEventListener("beforeunload", ev => {
+      // Setting any value other than undefined here will prevent the window
+      // from closing or reloading
+      ev.returnValue = true;
+    });
+
+    setSize.call(that, win);
   }
 
   function pollToConfigureWindow(args) {
@@ -62,6 +69,7 @@ export default function windowHandler() {
         "modal",
         `width=${width}, height=${height}, location=no, menubar=no, left=0`
       );
+      win.document.title = title;
 
       if (win === null || typeof win === "undefined") {
         console.log(
@@ -120,8 +128,6 @@ export default function windowHandler() {
           setSize.call(this, win);
         });
       });
-
-      setSize.call(this, win);
     }
   });
 

src/background/window-prefs.js

@@ -90,7 +90,10 @@ const windowPrefs = {
             event.preventDefault();
             event.newGuest = new BrowserWindow({
               ...options,
-              autoHideMenuBar: true
+              autoHideMenuBar: true,
+              closable: false,
+              enableLargerThanScreen: true,
+              title: ""
             });
 
             event.newGuest.removeMenu();