Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prop-default): updates default prop check #646

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

2xAA
Copy link
Member

@2xAA 2xAA commented Nov 8, 2021

handles boolean value checking properly

fixes #644

@2xAA 2xAA requested a review from TimPietrusky November 8, 2021 12:33
Copy link
Member

@TimPietrusky TimPietrusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works! THANK YOU <3

@TimPietrusky TimPietrusky merged commit 0bc4e10 into next Nov 9, 2021
@TimPietrusky TimPietrusky deleted the fix/644/booleanPropRecall branch November 9, 2021 21:50
2xAA pushed a commit that referenced this pull request Nov 9, 2021
# [3.19.0](3.18.0...3.19.0) (2021-11-09)

### Bug Fixes

* **color-picker:** fixes colorPicker ([#631](#631)) ([293e223](293e223))
* **font-list:** updates dependancy ([#624](#624)) ([5aeecae](5aeecae))
* **gallery:** fixes gallery item preview ([#629](#629)) ([3272fbc](3272fbc)), closes [#597](#597) [#526](#526)
* **groups:** fixes default value for groups inheritFrom ([#628](#628)) ([d80f5ef](d80f5ef)), closes [#627](#627)
* **loop:** adds context to update method ([#641](#641)) ([1178273](1178273))
* **output-window:** Set proper encoding ([#634](#634)) ([41335b3](41335b3))
* **prop-default:** updates default prop check ([#646](#646)) ([0bc4e10](0bc4e10)), closes [#644](#644)
* **rangecontrol:** fixes an infinite update loop ([#643](#643)) ([334e024](334e024))
* **release:** use node 14 ([dd05d88](dd05d88))
* removes menuBar from appearing on output windows ([#632](#632)) ([5d6ef6a](5d6ef6a))
* slow post message ([#623](#623)) ([cab2b82](cab2b82))
* **slow-start-up:** refactors worker/modv lifecycle and module loading ([#618](#618)) ([ea8a15d](ea8a15d)), closes [#617](#617)
* **smoothing:** fixes inputLink smoothing ([#630](#630)) ([24864e2](24864e2))
* **splash-screen:** moves styles into main app.vue only ([#638](#638)) ([a90a09a](a90a09a))

### Features

* **isf:** remove unused error message & temp folder from media manager ([#636](#636)) ([4dfb299](4dfb299))
* **kick:** adds option for kick as inputlink and adds u_kick uniform for shaders ([#616](#616)) ([6aeac7f](6aeac7f))
* **offline-support:** Include raster.css + fonts ([#622](#622)) ([ef217bb](ef217bb)), closes [#621](#621)

### Performance Improvements

* **module-inspector:** changes v-for key from id to index ([#625](#625)) ([c79cb81](c79cb81))
@2xAA
Copy link
Member Author

2xAA commented Nov 9, 2021

🎉 This PR is included in version 3.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@2xAA 2xAA added the released label Nov 9, 2021
2xAA pushed a commit that referenced this pull request Jan 7, 2022
# [3.19.0](3.18.0...3.19.0) (2021-11-09)

### Bug Fixes

* **color-picker:** fixes colorPicker ([#631](#631)) ([293e223](293e223))
* **font-list:** updates dependancy ([#624](#624)) ([5aeecae](5aeecae))
* **gallery:** fixes gallery item preview ([#629](#629)) ([3272fbc](3272fbc)), closes [#597](#597) [#526](#526)
* **groups:** fixes default value for groups inheritFrom ([#628](#628)) ([d80f5ef](d80f5ef)), closes [#627](#627)
* **loop:** adds context to update method ([#641](#641)) ([1178273](1178273))
* **output-window:** Set proper encoding ([#634](#634)) ([41335b3](41335b3))
* **prop-default:** updates default prop check ([#646](#646)) ([0bc4e10](0bc4e10)), closes [#644](#644)
* **rangecontrol:** fixes an infinite update loop ([#643](#643)) ([334e024](334e024))
* **release:** use node 14 ([dd05d88](dd05d88))
* removes menuBar from appearing on output windows ([#632](#632)) ([5d6ef6a](5d6ef6a))
* slow post message ([#623](#623)) ([cab2b82](cab2b82))
* **slow-start-up:** refactors worker/modv lifecycle and module loading ([#618](#618)) ([ea8a15d](ea8a15d)), closes [#617](#617)
* **smoothing:** fixes inputLink smoothing ([#630](#630)) ([24864e2](24864e2))
* **splash-screen:** moves styles into main app.vue only ([#638](#638)) ([a90a09a](a90a09a))

### Features

* **isf:** remove unused error message & temp folder from media manager ([#636](#636)) ([4dfb299](4dfb299))
* **kick:** adds option for kick as inputlink and adds u_kick uniform for shaders ([#616](#616)) ([6aeac7f](6aeac7f))
* **offline-support:** Include raster.css + fonts ([#622](#622)) ([ef217bb](ef217bb)), closes [#621](#621)

### Performance Improvements

* **module-inspector:** changes v-for key from id to index ([#625](#625)) ([c79cb81](c79cb81))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading "bool" from preset is not working (WIP)
2 participants