Delete unnecessary code for mirror (#2366)

* fix: delete unnecessary code for mirror Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make deps/install and format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * improve Backport Pull Request Title & Description Quality (#2373) Signed-off-by: kpango <kpango@vdaas.org> Co-authored-by: Kosuke Morimoto <ksk@vdaas.org> * fix: naming of variable Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Signed-off-by: kpango <kpango@vdaas.org> Co-authored-by: Yusuke Kato <kpango@vdaas.org> Co-authored-by: Kosuke Morimoto <ksk@vdaas.org>
vdaas · Feb 20, 2024 · 0af82a9 · 0af82a9
1 parent 8942871
commit 0af82a9
Show file tree

Hide file tree

Showing 13 changed files with 293 additions and 272 deletions.
diff --git a/apis/grpc/v1/mirror/mirror.go b/apis/grpc/v1/mirror/mirror.go
@@ -0,0 +1,23 @@
+//
+// Copyright (C) 2019-2024 vdaas.org vald team <vald@vdaas.org>
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// You may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+// Package mirror provides vald server interface
+package mirror
+
+const (
+	RPCServiceName  = "Mirror"
+	RegisterRPCName = "Register"
+)
diff --git a/apis/grpc/v1/vald/vald.go b/apis/grpc/v1/vald/vald.go
@@ -18,7 +18,6 @@
 package vald
 
 import (
-	"github.com/vdaas/vald/apis/grpc/v1/mirror"
 	grpc "google.golang.org/grpc"
 )
 
@@ -36,11 +35,6 @@ type ServerWithFilter interface {
 	FilterServer
 }
 
-type ServerWithMirror interface {
-	Server
-	mirror.MirrorServer
-}
-
 type UnimplementedValdServer struct {
 	UnimplementedInsertServer
 	UnimplementedUpdateServer
@@ -55,11 +49,6 @@ type UnimplementedValdServerWithFilter struct {
 	UnimplementedFilterServer
 }
 
-type UnimplementedValdServerWithMirror struct {
-	UnimplementedValdServer
-	mirror.UnimplementedMirrorServer
-}
-
 type Client interface {
 	InsertClient
 	UpdateClient
@@ -74,11 +63,6 @@ type ClientWithFilter interface {
 	FilterClient
 }
 
-type ClientWithMirror interface {
-	Client
-	mirror.MirrorClient
-}
-
 const PackageName = "vald.v1"
 
 const (
@@ -89,7 +73,6 @@ const (
 	RemoveRPCServiceName = "Remove"
 	ObjectRPCServiceName = "Object"
 	FilterRPCServiceName = "Filter"
-	MirrorRPCServiceName = "Mirror"
 )
 
 const (
@@ -143,8 +126,6 @@ const (
 	GetTimestampRPCName     = "GetTimestamp"
 	StreamGetObjectRPCName  = "StreamGetObject"
 	StreamListObjectRPCName = "StreamListObject"
-
-	RegisterRPCName = "Register"
 )
 
 type client struct {
@@ -156,11 +137,6 @@ type client struct {
 	ObjectClient
 }
 
-type clientWithMirror struct {
-	Client
-	mirror.MirrorClient
-}
-
 func RegisterValdServer(s *grpc.Server, srv Server) {
 	RegisterInsertServer(s, srv)
 	RegisterUpdateServer(s, srv)
@@ -175,11 +151,6 @@ func RegisterValdServerWithFilter(s *grpc.Server, srv ServerWithFilter) {
 	RegisterFilterServer(s, srv)
 }
 
-func RegisterValdServerWithMirror(s *grpc.Server, srv ServerWithMirror) {
-	RegisterValdServer(s, srv)
-	mirror.RegisterMirrorServer(s, srv)
-}
-
 func NewValdClient(conn *grpc.ClientConn) Client {
 	return &client{
 		NewInsertClient(conn),
@@ -190,10 +161,3 @@ func NewValdClient(conn *grpc.ClientConn) Client {
 		NewObjectClient(conn),
 	}
 }
-
-func NewValdClientWithMirror(conn *grpc.ClientConn) ClientWithMirror {
-	return &clientWithMirror{
-		Client:       NewValdClient(conn),
-		MirrorClient: mirror.NewMirrorClient(conn),
-	}
-}
diff --git a/internal/client/v1/client/mirror/mirror.go b/internal/client/v1/client/mirror/mirror.go
@@ -18,7 +18,6 @@ import (
 
 	"github.com/vdaas/vald/apis/grpc/v1/mirror"
 	"github.com/vdaas/vald/apis/grpc/v1/payload"
-	"github.com/vdaas/vald/apis/grpc/v1/vald"
 	"github.com/vdaas/vald/internal/errors"
 	"github.com/vdaas/vald/internal/net/grpc"
 	"github.com/vdaas/vald/internal/observability/trace"
@@ -69,7 +68,7 @@ func (c *client) GRPCClient() grpc.Client {
 }
 
 func (c *client) Register(ctx context.Context, in *payload.Mirror_Targets, opts ...grpc.CallOption) (res *payload.Mirror_Targets, err error) {
-	ctx, span := trace.StartSpan(grpc.WrapGRPCMethod(ctx, "internal/client/"+vald.RegisterRPCName), apiName+"/"+vald.RegisterRPCName)
+	ctx, span := trace.StartSpan(grpc.WrapGRPCMethod(ctx, "internal/client/"+mirror.RegisterRPCName), apiName+"/"+mirror.RegisterRPCName)
 	defer func() {
 		if span != nil {
 			span.End()

diff --git a/internal/test/mock/client/mirror_client_mock.go b/internal/test/mock/client/mirror_client_mock.go
@@ -16,13 +16,15 @@ package client
 import (
 	"context"
 
+	"github.com/vdaas/vald/apis/grpc/v1/mirror"
 	"github.com/vdaas/vald/apis/grpc/v1/payload"
 	"github.com/vdaas/vald/apis/grpc/v1/vald"
 	"github.com/vdaas/vald/internal/net/grpc"
 )
 
 type MirrorClientMock struct {
-	vald.ClientWithMirror
+	vald.Client
+	mirror.MirrorClient
 
 	InsertFunc            func(ctx context.Context, in *payload.Insert_Request, opts ...grpc.CallOption) (*payload.Object_Location, error)
 	UpdateFunc            func(ctx context.Context, in *payload.Update_Request, opts ...grpc.CallOption) (*payload.Object_Location, error)