💚 Add info tag for info metrics

Signed-off-by: vankichi <kyukawa315@gmail.com>
vdaas · Mar 4, 2024 · 1cd1add · 1cd1add
1 parent 9d67212
commit 1cd1add
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/internal/config/benchmark.go b/internal/config/benchmark.go
@@ -234,8 +234,8 @@ func (b *BenchmarkScenario) Bind() *BenchmarkScenario {
 
 // BenchmarkJobImageInfo represents the docker image information for benchmark job.
 type BenchmarkJobImageInfo struct {
-	Image      string `json:"image,omitempty"       yaml:"image"`
-	PullPolicy string `json:"pull_policy,omitempty" yaml:"pull_policy"`
+	Image      string `info:"image" json:"image,omitempty" yaml:"image"`
+	PullPolicy string `info:"pull_policy" json:"pull_policy,omitempty" yaml:"pull_policy"`
 }
 
 // Bind binds the actual data from the BenchmarkJobImageInfo receiver fields.

diff --git a/pkg/tools/benchmark/operator/config/config.go b/pkg/tools/benchmark/operator/config/config.go
@@ -19,7 +19,6 @@ package config
 
 import (
 	"github.com/vdaas/vald/internal/config"
-	"github.com/vdaas/vald/internal/log"
 )
 
 // GlobalConfig is type alias for config.GlobalConfig.
@@ -64,7 +63,6 @@ func NewConfig(path string) (cfg *Config, err error) {
 	} else {
 		cfg.JobImage = new(config.BenchmarkJobImageInfo)
 	}
-	log.Error(cfg)
 	return cfg, nil
 }
 

diff --git a/pkg/tools/benchmark/operator/usecase/benchmarkd.go b/pkg/tools/benchmark/operator/usecase/benchmarkd.go
@@ -96,7 +96,7 @@ func New(cfg *config.Config) (r runner.Runner, err error) {
 	if cfg.Observability.Enabled {
 		obs, err = observability.NewWithConfig(
 			cfg.Observability,
-			infometrics.New("benchmark_operator_info", "Benchmark Operator Info", *cfg.JobImage),
+			infometrics.New("benchmark_operator_info", "Benchmark Operator info", *cfg.JobImage),
 			backoffmetrics.New(),
 		)
 		if err != nil {