[REVERT THIS] temprally disable GetObject err details

vdaas · Aug 21, 2023 · 73620a2 · 73620a2
1 parent 04b5ad1
commit 73620a2
Showing 1 changed file with 15 additions and 16 deletions.
diff --git a/pkg/agent/core/ngt/handler/grpc/object.go b/pkg/agent/core/ngt/handler/grpc/object.go
@@ -21,7 +21,6 @@ import (
 	"github.com/vdaas/vald/apis/grpc/v1/payload"
 	"github.com/vdaas/vald/apis/grpc/v1/vald"
 	"github.com/vdaas/vald/internal/errors"
-	"github.com/vdaas/vald/internal/info"
 	"github.com/vdaas/vald/internal/log"
 	"github.com/vdaas/vald/internal/net/grpc"
 	"github.com/vdaas/vald/internal/net/grpc/codes"
@@ -125,21 +124,21 @@ func (s *server) GetObject(ctx context.Context, id *payload.Object_VectorRequest
 	}
 	vec, ts, err := s.ngt.GetObject(uuid)
 	if err != nil || vec == nil {
-		err = errors.ErrObjectNotFound(err, uuid)
-		err = status.WrapWithNotFound("GetObject API failed to remove request", err,
-			&errdetails.RequestInfo{
-				RequestId:   uuid,
-				ServingData: errdetails.Serialize(id),
-			},
-			&errdetails.ResourceInfo{
-				ResourceType: ngtResourceType + "/ngt.GetObject",
-				ResourceName: fmt.Sprintf("%s: %s(%s)", apiName, s.name, s.ip),
-			}, info.Get())
-		if span != nil {
-			span.RecordError(err)
-			span.SetAttributes(trace.StatusCodeNotFound(err.Error())...)
-			span.SetStatus(trace.StatusError, err.Error())
-		}
+		// err = errors.ErrObjectNotFound(err, uuid)
+		// err = status.WrapWithNotFound("GetObject API failed to remove request", err,
+		// 	&errdetails.RequestInfo{
+		// 		RequestId:   uuid,
+		// 		ServingData: errdetails.Serialize(id),
+		// 	},
+		// 	&errdetails.ResourceInfo{
+		// 		ResourceType: ngtResourceType + "/ngt.GetObject",
+		// 		ResourceName: fmt.Sprintf("%s: %s(%s)", apiName, s.name, s.ip),
+		// 	}, info.Get())
+		// if span != nil {
+		// 	span.RecordError(err)
+		// 	span.SetAttributes(trace.StatusCodeNotFound(err.Error())...)
+		// 	span.SetStatus(trace.StatusError, err.Error())
+		// }
 		return nil, err
 	}